Skip to content

CommandBarButton: High contrast hover states#4738

Merged
lynamemi merged 4 commits intomicrosoft:new_6.0from
lynamemi:commandBar-hc-hover
May 2, 2018
Merged

CommandBarButton: High contrast hover states#4738
lynamemi merged 4 commits intomicrosoft:new_6.0from
lynamemi:commandBar-hc-hover

Conversation

@lynamemi
Copy link
Copy Markdown
Collaborator

@lynamemi lynamemi commented May 2, 2018

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ npm run change

Description of changes

Ported this over to be merged into new_6.0 instead of master from here:
#4728

New is hovered on, Upload is a link (that's why it's green):
image

Focus areas to test

(optional)

@lynamemi lynamemi requested a review from cliffkoh May 2, 2018 17:33
@lynamemi lynamemi requested a review from micahgodbolt as a code owner May 2, 2018 17:33
Copy link
Copy Markdown
Contributor

@cliffkoh cliffkoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@cliffkoh
Copy link
Copy Markdown
Contributor

cliffkoh commented May 2, 2018

@micahgodbolt, can you please sign off as the codeowner for command bar?

@cliffkoh cliffkoh added this to the v6.0 milestone May 2, 2018
@lynamemi lynamemi merged commit edb598b into microsoft:new_6.0 May 2, 2018
@lynamemi lynamemi deleted the commandBar-hc-hover branch May 2, 2018 18:48
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants