Skip to content

Remove unused iconClassName prop from Nav.types #4634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 3 commits into from
Apr 23, 2018
Merged

Remove unused iconClassName prop from Nav.types #4634

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
594906c
Mark INavLink#iconClassName as deprecated. Use IIconProps.className i…
KevinTCoughlin Apr 20, 2018
cd61afd
+ changelog
KevinTCoughlin Apr 20, 2018
4f47d97
Update Nav.types.ts
dzearing Apr 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/keco-nav-iconClassName_2018-04-20-18-21.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Deprecates INavLink.iconClassName in favor of IIconProps.className.",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
3 changes: 2 additions & 1 deletion packages/office-ui-fabric-react/src/components/Nav/Nav.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,8 @@ export interface INavLink {
icon?: string;

/**
* Classname to apply to the icon link.
* iconClassName has been deprecated in favor of IIconProps. Use IIconProps.className instead.
Copy link
Collaborator

@oengusmacinog-zz oengusmacinog-zz Apr 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change IIconProps (the Type) to iconProps (the actual prop of type IIconProps you want to use).

Nitpicky I know, but clarity is everything in the documentation.

* @deprecated
*/
iconClassName?: string;

Expand Down