Skip to content

Addressing Issue #3634 - Accessibility: Panel should have aria-labelledby and aria-describedby like Dialog #4626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 3 commits into from
Apr 20, 2018
+16 −0
Merged

Addressing Issue #3634 - Accessibility: Panel should have aria-labelledby and aria-describedby like Dialog #4626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
baf6322
enable native props
oengusmacinog-zz Apr 19, 2018
b210952
update documentation
oengusmacinog-zz Apr 19, 2018
0374bf8
rush change
oengusmacinog-zz Apr 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/panel-nativeprops-3634_2018-04-19-23-53.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Added support for native props on Panel for the root div with class ms-Panel",
"type": "minor"
}
],
"packageName": "office-ui-fabric-react",
"email": "v-brgarl@microsoft.com"
}
4 changes: 4 additions & 0 deletions packages/office-ui-fabric-react/src/components/Panel/Panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ import * as React from 'react';
import {
BaseComponent,
css,
divProperties,
getId,
getNativeProps,
getRTL,
createRef
} from '../../Utilities';
Expand Down Expand Up @@ -102,6 +104,7 @@ export class Panel extends BaseComponent<IPanelProps, IPanelState> implements IP
const isOnRightSide = isRTL ? isLeft : !isLeft;
const headerTextId = headerText && id + '-headerText';
const customWidthStyles = (type === PanelType.custom) ? { width: customWidth } : {};
const nativeProps = getNativeProps(this.props, divProperties);

if (!isOpen && !isAnimating && !isHiddenOnDismiss) {
return null;
Expand Down Expand Up @@ -137,6 +140,7 @@ export class Panel extends BaseComponent<IPanelProps, IPanelState> implements IP
}
>
<div
{ ...nativeProps }
className={
css(
'ms-Panel',
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/Panel/PanelPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export class PanelPage extends React.Component<IComponentDemoPageProps, {}> {
title='Panel'
componentName='PanelExample'
componentUrl='https://github.com/OfficeDev/office-ui-fabric-react/tree/master/packages/office-ui-fabric-react/src/components/Panel'
allowNativeProps={ true }
exampleCards={
<div>
<ExampleCard title='Panel - Small Panel, Anchored Right, Fixed Width' code={ PanelSmallRightExampleCode }>
Expand Down