Skip to content

Searchbox: Clicking in front of input text puts cursor at the start of the text #4587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lynamemi merged 5 commits into from
Apr 18, 2018
Merged

Searchbox: Clicking in front of input text puts cursor at the start of the text #4587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f6fb0f5
Clicks before text set cursor to beginning of text
lynamemi Apr 17, 2018
cf5abd1
Add change file
lynamemi Apr 17, 2018
3575316
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
lynamemi Apr 18, 2018
a3ce1cf
Fix chrome bug and add cursor
lynamemi Apr 18, 2018
46fe46b
Updated snapshot
lynamemi Apr 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/searchbox-focus_2018-04-17-18-23.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "SearchBox: Clicks on element before input field set cursor to start of input text.",
"type": "minor"
}
],
"packageName": "office-ui-fabric-react",
"email": "lynam.emily@gmail.com"
}
18 changes: 16 additions & 2 deletions packages/office-ui-fabric-react/src/components/SearchBox/SearchBox.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,14 @@ export class SearchBoxBase extends BaseComponent<ISearchBoxProps, ISearchBoxStat
className={ classNames.root }
onFocusCapture={ this._onFocusCapture }
>
<div className={ classNames.iconContainer }>
<Icon className={ classNames.icon } iconName='Search' />
<div
className={ classNames.iconContainer }
onClick={ this._onClickFocus }
>
<Icon
className={ classNames.icon }
iconName='Search'
/>
</div>
<input
id={ id }
Expand Down Expand Up @@ -142,6 +148,14 @@ export class SearchBoxBase extends BaseComponent<ISearchBoxProps, ISearchBoxStat
}
}

private _onClickFocus = () => {
const inputElement = this._inputElement.value;
if (inputElement) {
this.focus();
inputElement.selectionStart = inputElement.selectionEnd = 0;
}
}

private _onFocusCapture = (ev: React.FocusEvent<HTMLElement>) => {
this.setState({
hasFocus: true
Expand Down
3 changes: 2 additions & 1 deletion packages/office-ui-fabric-react/src/components/SearchBox/SearchBox.styles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ export function getStyles(props: ISearchBoxStyleProps): ISearchBoxStyles {
width: 32,
textAlign: 'center',
transition: `width ${AnimationVariables.durationValue1}`,
color: palette.themePrimary
color: palette.themePrimary,
cursor: 'text'
},
hasFocus && {
width: 4,
Expand Down
2 changes: 2 additions & 0 deletions ...ges/office-ui-fabric-react/src/components/SearchBox/__snapshots__/SearchBox.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ exports[`SearchBox renders SearchBox correctly 1`] = `
ms-SearchBox-iconContainer
{
color: #0078d4;
cursor: text;
display: flex;
flex-direction: column;
flex-shrink: 0;
Expand All @@ -53,6 +54,7 @@ exports[`SearchBox renders SearchBox correctly 1`] = `
transition: width 0.167s;
width: 32px;
}
onClick={[Function]}
>
<i
aria-hidden={true}
Expand Down