Skip to content

mergeStyles: asynchronously reset the next style element being used #4574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 2 commits into from
Apr 17, 2018
Merged

mergeStyles: asynchronously reset the next style element being used #4574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcae702
Async registration of styling.
dzearing Apr 16, 2018
df596f6
Adding change file.
dzearing Apr 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@uifabric/merge-styles/async-style_2018-04-16-22-29.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@uifabric/merge-styles",
"comment": "mergeStyles: rules are now registered in separate styling objects, improving performance significantly.",
"type": "patch"
}
],
"packageName": "@uifabric/merge-styles",
"email": "[email protected]"
}
5 changes: 5 additions & 0 deletions packages/merge-styles/src/Stylesheet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,11 @@ export class Stylesheet {
private _getElement(): HTMLStyleElement | undefined {
if (!this._styleElement && typeof document !== 'undefined') {
this._styleElement = _createStyleElement();

// Reset the style element on the next frame.
window.requestAnimationFrame(() => {
this._styleElement = undefined;
});
}
return this._styleElement;
}
Expand Down