-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Picker/Autofill: fixes several minor bugs. #4569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
09873d8
Revert "FocusTrapZone does not correctly trap focus when last child i…
joschect ac6a5e5
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
joschect 4567e59
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
joschect 351a18d
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
joschect 2a629fb
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
joschect 09bd6c5
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
joschect 32e4092
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
joschect 0a4f039
minor picker fixes
joschect 2aeac1c
adding change file
joschect 3474c56
Undo change to examples
joschect 6d28041
Fix typo
joschect 6ed2573
remove space
joschect 81a2bcb
Merge branch 'minorpicker-fixes' of https://github.com/joschect/offic…
joschect 45540b5
Merge branch 'master' into minorpicker-fixes
joschect File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
11 changes: 11 additions & 0 deletions
11
common/changes/office-ui-fabric-react/minorpicker-fixes_2018-04-16-18-52.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "office-ui-fabric-react", | ||
| "comment": "Pickers: Several fixes regarding certain props", | ||
| "type": "minor" | ||
| } | ||
| ], | ||
| "packageName": "office-ui-fabric-react", | ||
| "email": "[email protected]" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in the conditional below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is a callback specifically for the input, there could be a case where something should happen only explicitly when input is blurred. However, the picker should only act when it loses focus entirely.