Skip to content

Fixes invalid aria-owns/ activedescendant attributes on BasePicker #4552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manishgarg1 merged 6 commits into from
Apr 18, 2018
Merged

Fixes invalid aria-owns/ activedescendant attributes on BasePicker #4552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
83860e0
Fixing invalid aria-owns field on BasePicker
rebeccaballantyne01 Apr 13, 2018
ec61114
Rush change log
rebeccaballantyne01 Apr 13, 2018
ba3ff71
Removing unnecessary !!
rebeccaballantyne01 Apr 13, 2018
803b1d6
Changing blank string to undefined
rebeccaballantyne01 Apr 16, 2018
b6154aa
Updating snapshots to use undefined as well
rebeccaballantyne01 Apr 16, 2018
cd17c1b
Fixes issue for active descendant
rebeccaballantyne01 Apr 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/rebeba-aria-owns-invalid_2018-04-13-21-39.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Updates aria-owns on BasePicker (and snapshot tests) so its only set when suggestions are rendered",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "rebeba@microsoft.com"
}
6 changes: 3 additions & 3 deletions packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ export class BasePicker<T, P extends IBasePickerProps<T>> extends BaseComponent<
onInputValueChange={ this.onInputChange }
suggestedDisplayValue={ suggestedDisplayValue }
aria-activedescendant={ activeDescendant }
aria-owns='suggestion-list'
aria-owns={ this.state.suggestionsVisible ? 'suggestion-list' : undefined }
aria-expanded={ !!this.state.suggestionsVisible }
aria-haspopup='true'
autoCapitalize='off'
Expand Down Expand Up @@ -745,8 +745,8 @@ export class BasePickerListBelow<T, P extends IBasePickerProps<T>> extends BaseP
onBlur={ this.onInputBlur }
onInputValueChange={ this.onInputChange }
suggestedDisplayValue={ suggestedDisplayValue }
aria-activedescendant={ 'sug-' + this.suggestionStore.currentIndex }
aria-owns='suggestion-list'
aria-activedescendant={ this.state.suggestionsVisible ? 'sug-' + this.suggestionStore.currentIndex : undefined }
aria-owns={ this.state.suggestionsVisible ? 'suggestion-list' : undefined }
aria-expanded={ !!this.state.suggestionsVisible }
aria-haspopup='true'
autoCapitalize='off'
Expand Down
4 changes: 2 additions & 2 deletions ...ages/office-ui-fabric-react/src/components/pickers/__snapshots__/BasePicker.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ exports[`Pickers BasePicker renders BasePicker correctly 1`] = `
aria-controls="selected-suggestion-alert"
aria-expanded={false}
aria-haspopup="true"
aria-owns="suggestion-list"
aria-owns={undefined}
autoCapitalize="off"
autoComplete="off"
className="ms-BasePicker-input"
Expand Down Expand Up @@ -113,7 +113,7 @@ exports[`Pickers TagPicker renders TagPicker correctly 1`] = `
aria-controls="selected-suggestion-alert"
aria-expanded={false}
aria-haspopup="true"
aria-owns="suggestion-list"
aria-owns={undefined}
autoCapitalize="off"
autoComplete="off"
className="ms-BasePicker-input"
Expand Down