Skip to content

Add focus method to Breadcrumb #4537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 3 commits into from
Apr 13, 2018
Merged

Add focus method to Breadcrumb #4537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c70c6bb
Add focus method to Breadcrumb
Apr 12, 2018
8dc53a9
Add change file
Apr 12, 2018
6bdc3da
Refactor code based on BaseExtendedPicker.tsx
Apr 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/breadcrumbFocus_2018-04-12-22-52.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Add focus method to Breadcrumb",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "v-hudole@microsoft.com"
}
16 changes: 14 additions & 2 deletions packages/office-ui-fabric-react/src/components/Breadcrumb/Breadcrumb.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import * as React from 'react';
import {
BaseComponent,
css,
getRTL
getRTL,
createRef
} from '../../Utilities';
import { FocusZone, FocusZoneDirection } from '../../FocusZone';
import { Link } from '../../Link';
Expand Down Expand Up @@ -31,10 +32,21 @@ export class Breadcrumb extends BaseComponent<IBreadcrumbProps, any> {
maxDisplayedItems: 999
};

protected focusZone = createRef<FocusZone>();

constructor(props: IBreadcrumbProps) {
super(props);
}

/**
* Sets focus to the first breadcrumb link.
*/
public focus(): void {
if (this.focusZone.value) {
this.focusZone.value.focus();
}
}

public render() {
const { onReduceData = this._onReduceData, maxDisplayedItems, items } = this.props;
const breadCrumbData: IBreadCrumbData = {
Expand Down Expand Up @@ -93,7 +105,7 @@ export class Breadcrumb extends BaseComponent<IBreadcrumbProps, any> {
role='navigation'
aria-label={ ariaLabel }
>
<FocusZone direction={ FocusZoneDirection.horizontal } >
<FocusZone componentRef={ this.focusZone } direction={ FocusZoneDirection.horizontal } >
<ol className={ css('ms-Breadcrumb-list', styles.list) }>
{ renderedOverflowItems && renderedOverflowItems.length !== 0 && (
<li className={ css('ms-Breadcrumb-overflow', styles.overflow) } key={ OVERFLOW_KEY }>
Expand Down
5 changes: 4 additions & 1 deletion packages/office-ui-fabric-react/src/components/Breadcrumb/Breadcrumb.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ import { IIconProps } from '../Icon';
import { IRenderFunction, IComponentAs } from '../../Utilities';

export interface IBreadcrumb {

/**
* Sets focus to the first breadcrumb link.
*/
focus(): void;
}

export interface IBreadcrumbProps extends React.Props<Breadcrumb> {
Expand Down