-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Docs: Convert document Overviews and Best Practices to markdown #4512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Jahnp
merged 24 commits into
microsoft:master
from
jordandrako:docs/convert-to-markdown
Apr 17, 2018
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
3d856ff
Convert getting started page and status page.
3eb00df
First wave of MD files.
ef990d2
Use markdown in example page wave 1
97dc75a
Wave 2
41d1d9a
Initial code owners
6ca7912
Wave 3
4737ce7
changes
a597cf7
Fix Persona owners
8465430
Add link to Icon docs to IconButton
6ff7893
Use component page for Theme page
f836177
Better themes documentation.
ea6668d
remove commented code
b4dbd48
clean
bfd4955
nit
2770413
Merge master
jordandrako e070a5b
Add opt-in for @deprecated comments for documentation.
b87e368
Add section on loading themes to Overview.
029b223
Fix mutating state to get rid of console error
3044e6e
Switch to getTheme from loadTheme, add not for deprecated colors.
4277f43
changes
91dbca3
remove console.logs
e5a8c30
Fix code block line height
jordandrako 9b51eac
Merge branch 'master' into docs/convert-to-markdown
f68cfc0
changes
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
common/changes/@uifabric/example-app-base/docs-convert-to-markdown_2018-04-16-23-02.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@uifabric/example-app-base", | ||
| "comment": "Fix code block line-height", | ||
| "type": "patch" | ||
| } | ||
| ], | ||
| "packageName": "@uifabric/example-app-base", | ||
| "email": "[email protected]" | ||
| } |
11 changes: 11 additions & 0 deletions
11
common/changes/@uifabric/styling/docs-convert-to-markdown_2018-04-14-00-37.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@uifabric/styling", | ||
| "comment": "Add opt-in @deprecated comments", | ||
| "type": "minor" | ||
| } | ||
| ], | ||
| "packageName": "@uifabric/styling", | ||
| "email": "[email protected]" | ||
| } |
11 changes: 11 additions & 0 deletions
11
common/changes/@uifabric/styling/docs-convert-to-markdown_2018-04-16-23-02.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@uifabric/styling", | ||
| "comment": "Fix deprecated semantic slots returning empty strings", | ||
| "type": "patch" | ||
| } | ||
| ], | ||
| "packageName": "@uifabric/styling", | ||
| "email": "[email protected]" | ||
| } |
11 changes: 11 additions & 0 deletions
11
common/changes/office-ui-fabric-react/docs-convert-to-markdown_2018-04-11-23-54.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "office-ui-fabric-react", | ||
| "comment": "Convert documentation to markdown for HIG.", | ||
| "type": "patch" | ||
| } | ||
| ], | ||
| "packageName": "office-ui-fabric-react", | ||
| "email": "[email protected]" | ||
| } |
11 changes: 11 additions & 0 deletions
11
common/changes/office-ui-fabric-react/docs-convert-to-markdown_2018-04-14-00-37.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "office-ui-fabric-react", | ||
| "comment": "Revamp Themes documentation", | ||
| "type": "patch" | ||
| } | ||
| ], | ||
| "packageName": "office-ui-fabric-react", | ||
| "email": "[email protected]" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
packages/office-ui-fabric-react/src/components/Breadcrumb/docs/BreadcrumbDonts.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - Don't use Breadcrumbs as a primary way to navigate an app or site. |
1 change: 1 addition & 0 deletions
1
packages/office-ui-fabric-react/src/components/Breadcrumb/docs/BreadcrumbDos.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - Place Breadcrumbs at the top of a page, above a list of items, or above the main content of a page. |
3 changes: 3 additions & 0 deletions
3
...ges/office-ui-fabric-react/src/components/Breadcrumb/docs/BreadcrumbOverview.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Breadcrumbs should be used as a navigational aid in your app or site. They indicate the current page’s location within a hierarchy and help the user understand where they are in relation to the rest of that hierarchy. They also afford one-click access to higher levels of that hierarchy. | ||
|
|
||
| Breadcrumbs are typically placed, in horizontal form, under the masthead or navigation of an experience, above the primary content area. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/office-ui-fabric-react/src/components/Button/docs/ButtonDonts.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| - Don't use generic labels like "Ok," especially in the case of an error; errors are never "Ok." | ||
| - Don’t place the default focus on a button that destroys data. Instead, place the default focus on the button that performs the "safe act" and retains the content (i.e. "Save") or cancels the action (i.e. "Cancel"). | ||
| - Don’t use a button to navigate to another place, use a link instead. The exception is in a wizard where "Back" and "Next" buttons may be used. | ||
| - Don’t put too much text in a button - try to keep the length of your text to a minimum. | ||
| - Don't put anything other than text in a button. |
11 changes: 11 additions & 0 deletions
11
packages/office-ui-fabric-react/src/components/Button/docs/ButtonDos.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| - Make sure the label conveys a clear purpose of the button to the user. | ||
| - Button labels must describe the action the button will perform and should include a verb. Use concise, specific, self-explanatory labels, usually a single word. | ||
| - Buttons should always include a noun if there is any room for interpretation about what the verb operates on. | ||
| - Consider the affect localization will have on the button and what will happen to components around it. | ||
| - If the button’s label content is dynamic, consider how the button will resize and what will happen to components around it. | ||
| - Use only a single line of text in the label of the button. | ||
| - Expose only one or two buttons to the user at a time, for example, "Accept" and "Cancel". If you need to expose more actions to the user, consider using checkboxes or radio buttons from which the user can select actions, with a single command button to trigger those actions. | ||
| - Show only one primary button that inherits theme color at rest state. In the event there are more than two buttons with equal priority, all buttons should have neutral backgrounds. | ||
| - "Submit", "OK", and "Apply" buttons should always be styled as primary buttons. When "Reset" or "Cancel" buttons appear alongside one of the above, they should be styled as secondary buttons. | ||
| - Default buttons should always perform safe operations. For example, a default button should never delete. | ||
| - Use task buttons to cause actions that complete a task or cause a transitional task. Do not use buttons to toggle other UX in the same context. For example, a button may be used to open an interface area but should not be used to open an additional set of components in the same interface. |
7 changes: 7 additions & 0 deletions
7
packages/office-ui-fabric-react/src/components/Button/docs/ButtonOverview.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| Buttons are best used to enable a user to commit a change or complete steps in a task. They are typically found inside forms, dialogs, panels or pages. An example of their usage is confirming the deletion of a file in a confirmation dialog. | ||
|
|
||
| When considering their place in a layout, contemplate the order in which a user will flow through the UI. As an example, in a form, the individual will need to read and interact with the form fields before submiting the form. Therefore, as a general rule, the button should be placed at the bottom of the UI container (a dialog, panel, or page) which holds the related UI elements. | ||
|
|
||
| While buttons can technically be used to navigate a user to another part of the experience, this is not recommended unless that navigation is part of an action or their flow. | ||
|
|
||
| Note that both iconProps and menuIconProps take <a href='#/components/icon'>IIconProps</a> to specify name and type. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to use the same code owners as the rest of the component for now, but over time we'll want to find design owners who can review the usage guidelines.