Skip to content

SearchBox: Padding fixes #4506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lynamemi merged 3 commits into from
Apr 10, 2018
Merged

SearchBox: Padding fixes #4506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ee0b6c
Fix padding left and add padding top and bottom
lynamemi Apr 10, 2018
c7f21a5
Added change file
lynamemi Apr 10, 2018
948ebf0
Updated snapshot
lynamemi Apr 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/searchbox-polish_2018-04-10-17-12.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "SearchBox: Fix padding left and add padding top and bottom to fix the field overlapping the border.",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "lynam.emily@gmail.com"
}
7 changes: 5 additions & 2 deletions packages/office-ui-fabric-react/src/components/SearchBox/SearchBox.styles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ export function getStyles(props: ISearchBoxStyleProps): ISearchBoxStyles {
flexDirection: 'row',
flexWrap: 'nowrap',
alignItems: 'stretch',
padding: '0 0 0 8px',
// The 1px top and bottom padding ensure the input field does not overlap the border
Copy link
Copy Markdown
Member

@Jahnp Jahnp Apr 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirming--these get RTL-ified automatically, right?

Copy link
Copy Markdown
Collaborator Author

@lynamemi lynamemi Apr 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 90% sure js styling does handle this automagically. I'll confirm.

Copy link
Copy Markdown
Member

@micahgodbolt micahgodbolt Apr 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, RTL is automatic

padding: '1px 0 1px 4px',
border: `1px solid ${palette.neutralTertiary}`,
height: 32,
selectors: {
Expand Down Expand Up @@ -61,7 +62,9 @@ export function getStyles(props: ISearchBoxStyleProps): ISearchBoxStyles {
underlined && [
'is-underlined',
{
borderWidth: '0 0 1px 0'
borderWidth: '0 0 1px 0',
// Underlined SearchBox has a larger padding left to vertically align with the waffle in product
padding: '1px 0 1px 8px'
}
],
underlined && disabled && {
Expand Down
6 changes: 3 additions & 3 deletions ...ges/office-ui-fabric-react/src/components/SearchBox/__snapshots__/SearchBox.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ exports[`SearchBox renders SearchBox correctly 1`] = `
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
padding-bottom: 0;
padding-left: 8px;
padding-bottom: 1px;
padding-left: 4px;
padding-right: 0;
padding-top: 0;
padding-top: 1px;
}
@media screen and (-ms-high-contrast: active){& {
border: 1px solid WindowText;
Expand Down