Skip to content

Contextual Menu: Moved the creation of Splitbutton containers into the constructor #4495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christiango merged 2 commits into from
Apr 9, 2018
Merged

Contextual Menu: Moved the creation of Splitbutton containers into the constructor #4495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac8ddf7
moved the creation of split button containers into the constructor
Apr 9, 2018
b2cdf85
addeed change file
Apr 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...s/office-ui-fabric-react/chiechan-fixCreationOfSplitButtonContainer_2018-04-09-16-47.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Contexual Menu: Move SplitButtonContainer to be defined in the constructor instead of ComponentDidMount",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "chiechan@microsoft.com"
}
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ export class ContextualMenu extends BaseComponent<IContextualMenuProps, IContext

this._isFocusingPreviousElement = false;
this._isScrollIdle = true;
this._splitButtonContainers = new Map();
}

public dismiss = (ev?: any, dismissAll?: boolean) => {
Expand Down Expand Up @@ -141,7 +142,6 @@ export class ContextualMenu extends BaseComponent<IContextualMenuProps, IContext
// Invoked once, only on the client (not on the server), immediately after the initial rendering occurs.
public componentDidMount() {
this._events.on(this._targetWindow, 'resize', this.dismiss);
this._splitButtonContainers = new Map();
if (this.props.onMenuOpened) {
this.props.onMenuOpened(this.props);
}
Expand Down