Skip to content

ScrollablePane: Optimization on how component works #4491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leddie24 merged 48 commits into from
May 4, 2018
Merged

ScrollablePane: Optimization on how component works #4491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
2ae8032
Fix sticky top behavior. Make inner div of ScrollablePane scrollable…
edwlmsft Apr 5, 2018
2534902
Fix sticky footer behavior
edwlmsft Apr 6, 2018
351b509
Remove unused state placeholderHeight. clean up onScrollEvent to onl…
edwlmsft Apr 6, 2018
d7befce
Add stickyPosition prop back
edwlmsft Apr 6, 2018
2e6f1eb
Remove stickyBelowContainer from handle.
edwlmsft Apr 6, 2018
4cc5960
Revert details list example. Fix distanceFromTop calculation
edwlmsft Apr 6, 2018
30b8c79
Fix unmounting sticky. Fix ScrollablePane not setting correct height…
edwlmsft Apr 6, 2018
de0424b
Update subscribers when DOM changes in scrollablePane. Add back Deta…
edwlmsft Apr 6, 2018
0fe99c9
Clean up inline sticky styles
edwlmsft Apr 6, 2018
92d4db5
Remove "testing testing" from default example
edwlmsft Apr 6, 2018
de3070c
Set stickyClassName on nonStickyContent if Sticky component is sticky…
edwlmsft Apr 6, 2018
b72e391
Remove unused _stickyBelow/_stickyAbove from ScrollablePane. Clean u…
edwlmsft Apr 6, 2018
e4ab481
black to $ms-color-black. Set overflow-x to auto and overflow-y to h…
edwlmsft Apr 6, 2018
7fe6b8c
Remove unused ref _stickyBelowContainerRef
edwlmsft Apr 7, 2018
7992359
Add getter for contentContainer
edwlmsft Apr 7, 2018
0397c02
Fix initial scroll position prop not working properly. Only set sta…
edwlmsft Apr 8, 2018
0082fb4
Simplify sortSticky function. Clean up _addtoStickyContainer function…
edwlmsft Apr 9, 2018
a143c76
Add back in detailslist example
edwlmsft Apr 9, 2018
ca65251
Fix linting
edwlmsft Apr 9, 2018
b4a7820
Remove redundant check for canStickyTop/Bottom in updateStickyRefHeig…
edwlmsft Apr 9, 2018
697abf8
nit: cleaner code in _addToStickyContainer
edwlmsft Apr 10, 2018
9e012ff
Fix lint
edwlmsft Apr 11, 2018
5d894de
Add aria-hidden to render for Sticky. Add comment in notifySubscribers.
edwlmsft Apr 13, 2018
0ff1aec
move sortSticky to component mount only. Add setDistanceFromTop func…
edwlmsft Apr 16, 2018
57faff0
Return undefined instead of null in _getBackground
edwlmsft Apr 17, 2018
8741d7c
merge master
edwlmsft Apr 17, 2018
7d86387
Fix merge conflict
edwlmsft Apr 17, 2018
0b6badb
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
edwlmsft Apr 19, 2018
3799d87
Remove unused StickyPosition
edwlmsft Apr 19, 2018
a7aeb07
Only updateStickyRefHeights in Sticky if state changes. Change from …
edwlmsft Apr 22, 2018
aac9e53
Add mutationObserver to check for Sticky component state changes
edwlmsft Apr 22, 2018
0080b46
Change scrollablePane didUpdate to notify when stickyTop/Bottom heigh…
edwlmsft Apr 23, 2018
0313824
Update scrollablePane styles to use position absolute. Update defaul…
edwlmsft Apr 23, 2018
28709a7
Fix default example to not have duplicate colors
edwlmsft Apr 23, 2018
78a298f
Update details list example
edwlmsft Apr 23, 2018
59f2ab7
Update ScrollablePane Do's. Update example css
edwlmsft Apr 23, 2018
0ef10da
Update sticky donts
edwlmsft Apr 23, 2018
c55aad9
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
edwlmsft Apr 23, 2018
b8aab4c
Fix lint
edwlmsft Apr 23, 2018
489d246
more lint
edwlmsft Apr 23, 2018
ac905dc
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
edwlmsft Apr 23, 2018
474bf81
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
edwlmsft May 2, 2018
1fa5a01
Set refs as private properties of Sticky. Remove background #fff fro…
edwlmsft May 2, 2018
e04d2a7
Fix order of public/private in Sticky
edwlmsft May 2, 2018
00a8b44
Set width on stickyabove/below instead of Sticky component itself.
edwlmsft May 2, 2018
b49fa90
Get rid of maxheight styles. Add throttle to scroll event. Change no…
edwlmsft May 3, 2018
c5b0ef3
Update Do's
edwlmsft May 3, 2018
f37feb8
Add change file
edwlmsft May 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/edwl-fixScrollablePaneBehavior_2018-05-04-00-03.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "ScrollablePane: Optimizations on how component functions. Change positioning from inheriting height/maxHeight of parent element to use position: absolute",
"type": "minor"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
Loading