Conversation
| <FocusZone direction={ FocusZoneDirection.horizontal }> | ||
| <ul | ||
| className={ css('ms-Pivot', styles.root, | ||
| className={ css('ms-Pivot', styles.root, this.props.className, |
There was a problem hiding this comment.
This is the wrong place to put the className.
It needs to live on the outmost div element. Otherwise the consumer can't make it flexGrow: 1.
There was a problem hiding this comment.
See line 94.
I would recommend we use getNativeProps and mix native props into the root div.
There was a problem hiding this comment.
don't want this to go stale. :)
There was a problem hiding this comment.
Yes! So sorry about the delay. Just pushed the changes. Let me know what you think.
There was a problem hiding this comment.
Working on the merge conflict.
|
|
||
| return ( | ||
| <div> | ||
| <div { ...divProps } > |
There was a problem hiding this comment.
nit, space at end.
Also update tests :)
|
Any updates on how to override the Pivot styles? |
|
As of #5324, you should now be able to use the IPivotStyles interface to define a function or an object for the |
4 participants
Pull request checklist
$ npm run changeDescription of changes
Add optional className to Pivot props to allow customization of component styles.