Skip to content

Tooltip: Adding an option for longer delay #4433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 6 commits into from
Apr 2, 2018
Merged

Tooltip: Adding an option for longer delay #4433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
94c1ad1
Merge pull request #1 from OfficeDev/master
kysedate Feb 1, 2018
ab295d5
Merge pull request #2 from OfficeDev/master
kysedate Mar 15, 2018
a09419a
Merge pull request #3 from OfficeDev/master
kysedate Mar 29, 2018
742bd49
Adding a longer delay as an option to the tooltip comonent. Before th…
kysedate Apr 2, 2018
43b0136
change
kysedate Apr 2, 2018
6eb6179
Changing the delay to 500ms after talking to June
kysedate Apr 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/kysedate-tooltip-long-delay_2018-04-02-17-42.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Adding a longer delay as an option to the tooltip comonent. Before there was only a medium (300ms) or zero (0ms) delay.",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "kysedate@microsoft.com"
}
4 changes: 4 additions & 0 deletions packages/office-ui-fabric-react/src/components/Tooltip/Tooltip.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
&.hasMediumDelay {
animation-delay: 300ms;
}

&.hasLongDelay {
animation-delay: 500ms;
}
}

.content {
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/Tooltip/Tooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export class Tooltip extends BaseComponent<ITooltipProps, any> {
AnimationClassNames.fadeIn200,
styles.root,
(delay === TooltipDelay.medium) && styles.hasMediumDelay,
(delay === TooltipDelay.long) && styles.hasLongDelay,
(maxWidth !== null) && { maxWidth: maxWidth },
calloutProps ? calloutProps.className : undefined,
this.props.className
Expand Down
3 changes: 2 additions & 1 deletion packages/office-ui-fabric-react/src/components/Tooltip/Tooltip.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,5 +65,6 @@ export interface ITooltipProps extends React.HTMLAttributes<HTMLDivElement | Too

export enum TooltipDelay {
zero = 0,
medium = 1
medium = 1,
long = 2
}