Skip to content

Dropdowns not editable #4422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 2 commits into from
Mar 31, 2018
Merged

Dropdowns not editable #4422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f9e8a1
dropdown role is listbox
natalieethell Mar 30, 2018
92205f7
change file
natalieethell Mar 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/dropdownsNotEditable_2018-03-30-23-06.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Dropdown: aria role is `listbox` instead of `textbox`",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "naethell@microsoft.com"
}
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/Dropdown/Dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ export class Dropdown extends BaseComponent<IDropdownInternalProps, IDropdownSta
(errorMessage && errorMessage.length > 0 ? styles.titleIsError : null))
}
aria-atomic={ true }
role='textbox'
role='listbox'
aria-readonly='true'
>
{ // If option is selected render title, otherwise render the placeholder text
Expand Down
4 changes: 2 additions & 2 deletions packages/office-ui-fabric-react/src/components/Dropdown/__snapshots__/Dropdown.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ exports[`Dropdown multi-select Renders multiselect Dropdown correctly 1`] = `
aria-readonly="true"
className="ms-Dropdown-title ms-Dropdown-titleIsPlaceHolder"
id="Dropdown94-option"
role="textbox"
role="listbox"
/>
<span
className="ms-Dropdown-caretDownWrapper"
Expand Down Expand Up @@ -76,7 +76,7 @@ exports[`Dropdown single-select Renders single-select Dropdown correctly 1`] = `
aria-readonly="true"
className="ms-Dropdown-title ms-Dropdown-titleIsPlaceHolder"
id="Dropdown0-option"
role="textbox"
role="listbox"
/>
<span
className="ms-Dropdown-caretDownWrapper"
Expand Down