Skip to content

Pickers: Fix suggestions not having proper value selected #4408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joschect merged 14 commits into from
Mar 30, 2018
Merged

Pickers: Fix suggestions not having proper value selected #4408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
09873d8
Revert "FocusTrapZone does not correctly trap focus when last child i…
joschect Mar 15, 2018
ac6a5e5
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
joschect Mar 20, 2018
4567e59
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
joschect Mar 21, 2018
351a18d
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
joschect Mar 23, 2018
2a629fb
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
joschect Mar 28, 2018
ff19db2
fix picker suggestions and add many tests
joschect Mar 29, 2018
7f4494a
adding snap file
joschect Mar 29, 2018
2e423b6
adding change file
joschect Mar 29, 2018
af252a4
improve test
joschect Mar 29, 2018
25316a5
fix tests and config
joschect Mar 29, 2018
8d5e717
revert test changes
joschect Mar 29, 2018
82dca88
last test update
joschect Mar 30, 2018
2928672
update test name and snapshot
joschect Mar 30, 2018
81ae8a5
remove tests to expedite checkin
joschect Mar 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/joschect-fix-pickers-suggestions_2018-03-29-23-30.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Pickers: fix bug where suggestions wouldn't have correct value selected",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/pickers/Suggestions/Suggestions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ export class Suggestions<T> extends BaseComponent<ISuggestionsProps<T>, ISuggest
>
{ suggestions.map((suggestion, index) =>
<div
ref={ this._selectedElement }
ref={ suggestion.selected ? this._selectedElement : '' }
// tslint:disable-next-line:no-string-literal
key={ (suggestion.item as any)['key'] ? (suggestion.item as any)['key'] : index }
id={ 'sug-' + index }
Expand Down