-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Persona: complete mergeStyles conversion and some small refactoring, add some styling functions. #4382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jordandrako
merged 71 commits into
microsoft:master
from
jordandrako:mergeStyles/persona-part2
Apr 9, 2018
Merged
Persona: complete mergeStyles conversion and some small refactoring, add some styling functions. #4382
Changes from 61 commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
28c97b5
Add zIndex variables
0236305
Make zIndex a namespace
50f5437
Start converting styles
fb5a0f4
Add noWrap general function
25b9a98
Add contrast colors
aeed10f
Add styles up to isAway modifier
80fccfa
Finish adding styles from scss, comment sections.
c8aaafd
Add temporary className strings
78da7f2
EOD
9e92ebe
EOD:
9b8c8be
Get styles 99% accurate.
e7d223d
Update types to shared.
b6525fe
Update exports
5370ee8
Export PersonaCoinBase from PersonaCoin.tsx
bd78c17
Finish PersonaPresenceBase
59a4ce3
Cleanup and adjust types
e0f5ea3
Update test for decorated Persona
1eed711
Delete sass files
16350cd
Delete PersonaConsts file (logic is now in styles files)
e1d9fc3
Update Snapshots
c1c972f
Add black-on-white media query
e0cea16
Fix high contrast styles, remove unused styles and consts
f387c7e
Organize and cleanup
9c5c7dc
Remove ampersands for High Contrast nesting bug workaround.
a340976
Move Persona render funtion types
bee0413
Enable getStyles as prop
6b36f14
Merge Master, resolve conflict with IPersonaProps componentRef.
e025b51
Fix conflicts
0bcb20a
Update snapshots
c6d114b
Fix all ":after" elements getting styles applied.
6f56372
Remove redundant styles
0b36bb1
Make secondaryText default height const
4e35d93
Increase readability
80275c2
Add newlines between props
e022670
Remove bang from getClassNames(getStyles) to allow null.
bfc5279
Add some more comments and some more cleaning
95e2ea6
External personaSize and personaPresenceSize
d0d16ac
Reintroduce PersonaConsts for use in styles files.- personaSize names…
42fa3f5
Merge master, fix allowPhoneInitials conflicts
0956686
Cut down on repeating styles
bbe5f2d
Remove deprecated Placeholder className (not used)
43c3b23
Remove zIndex API.
92ac11e
Use className from coinProps if it exists,
0839ce7
Update ActivityItem snapshot
b7f7083
finish removing zIndex
0e73517
Add showIcon prop
176f2c2
Remove display: none styles from presenceIcon
a8038cd
Modify coinSize related consts to adhere to IStyleSet.
3f1c860
Split Icon into private render method to conditionally render.
b611433
Remove showIcon prop.
3d4f956
Change to const
7946509
npm run change output
3af9b45
Fix ImageFitStyles for both RTL and LTR
fc62a9f
Use semantic color
8b1cb9e
Use border instead of box-shadow
3ab7396
Update snapshots
cb4782e
Remove new contrast colors and selector
40d5236
Add backgroundClip to IRawStyleBase
c006bf9
Major cleanup:
93d4aed
Add backgroundClip to lessen bleed on Edge.
a3dcb2f
Remove some added features from changelog
e853fd9
remove display property
146d607
Better documentation
34146e8
More documentation
c3bfbc7
nit
e6edd59
Update snapshot
09d8c4d
revert
jordandrako e78c886
Bump bundlesize .1kB
jordandrako 2a02099
Remove fallback
jordandrako 3ac4134
Remove fallback
jordandrako 307919a
Merge branch 'master' into mergeStyles/persona-part2
jordandrako File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
common/changes/@uifabric/styling/mergeStyles-persona-part2_2018-04-04-20-44.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@uifabric/styling", | ||
| "comment": "Add noWrap style set.", | ||
| "type": "minor" | ||
| } | ||
| ], | ||
| "packageName": "@uifabric/styling", | ||
| "email": "[email protected]" | ||
| } |
11 changes: 11 additions & 0 deletions
11
common/changes/office-ui-fabric-react/mergeStyles-persona-part2_2018-04-04-20-44.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "office-ui-fabric-react", | ||
| "comment": "Convert Persona and PersonaCoin and PersonaPresence to mergeStyles. Create IPersonaSharedProps for props that apply to Persona and PersonaCoin and PersonaPresence. Other refactors.", | ||
| "type": "minor" | ||
| } | ||
| ], | ||
| "packageName": "office-ui-fabric-react", | ||
| "email": "[email protected]" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| export * from './components/Persona/PersonaCoin'; | ||
| export * from './components/Persona/Persona.types'; | ||
| export * from './components/Persona/PersonaConsts'; | ||
| export * from './components/Persona/index'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should also note it doesn't work in IE