Skip to content

Checkbox: text should be selectable, icon shouldn't. #4378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 3 commits into from
Mar 27, 2018
Merged

Checkbox: text should be selectable, icon shouldn't. #4378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
843f544
Updating checkbox select.
dzearing Mar 27, 2018
a21506b
addin change.
dzearing Mar 27, 2018
3f8c361
Fix snapshot.
dzearing Mar 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/checkbox_2018-03-27-15-24.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Checkbox: label text should be selectable, but not the checkmark icons.",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/Checkbox/Checkbox.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ export const getStyles = memoizeFunction((
alignItems: 'center',
cursor: 'pointer',
position: 'relative',
userSelect: 'none',
textAlign: 'left'
},
labelReversed: {
Expand All @@ -73,6 +72,7 @@ export const getStyles = memoizeFunction((
transitionProperty: 'background, border, border-color',
transitionDuration: MS_CHECKBOX_TRANSITION_DURATION,
transitionTimingFunction: MS_CHECKBOX_TRANSITION_TIMING,
userSelect: 'none',

/* incase the icon is bigger than the box */
overflow: 'hidden'
Expand Down
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/Checkbox/__snapshots__/Checkbox.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ exports[`Checkbox renders Checkbox correctly 1`] = `
margin-top: 0;
position: relative;
text-align: left;
user-select: none;
}
htmlFor="checkbox-0"
>
Expand All @@ -101,6 +100,7 @@ exports[`Checkbox renders Checkbox correctly 1`] = `
transition-duration: 200ms;
transition-property: background, border, border-color;
transition-timing-function: cubic-bezier(.4, 0, .23, 1);
user-select: none;
width: 20px;
}
>
Expand Down