Skip to content

Remove a redundant "value" prop in ComboBox multi select example to eliminate confusing behaviors. #4366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 31 commits into from
Mar 27, 2018
Merged

Remove a redundant "value" prop in ComboBox multi select example to eliminate confusing behaviors. #4366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
ec3516c
Add multiSelect for ComboBox
Feb 6, 2018
86d985a
Merge from master
Feb 6, 2018
17f52e1
Unbreak a unit test
Feb 7, 2018
7155aa8
rush change
Feb 7, 2018
fee97bd
Merge from upstream
Mar 6, 2018
f81f595
bug fixes
Mar 15, 2018
bd787a3
Merge from upstream
Mar 15, 2018
7cd611f
Merge from upstream and resolve local build issues
Mar 15, 2018
b15187c
Fix merge styles
Mar 16, 2018
abc9efd
Fix pending background
Mar 16, 2018
78395cb
Unbreak unit test cases
Mar 16, 2018
13897db
Merge from upstream
Mar 19, 2018
558252d
Fix the merge
Mar 19, 2018
bc79fab
Add controled multi-select in the example page to make sure onChanged…
Mar 20, 2018
634d9a8
Resolve conflicts from upstream
Mar 20, 2018
09a52e7
Remove trailing white spaces
Mar 20, 2018
22c8e08
Fix bug: enter key will not trigger onChanged
Mar 20, 2018
94753a9
Dummy change to trigger another build
Mar 21, 2018
6934c24
Merge upstream and resolve conflict
Mar 22, 2018
143e5ea
refactor
Mar 22, 2018
da6751a
Fix some minor bugs
Mar 22, 2018
76cffe7
Update some comments for ComboBox
Mar 23, 2018
2da3aab
Merge from upstream and resolve conflicts
Mar 23, 2018
3ca4262
Minor bug fixes to the example page
Mar 23, 2018
6bf6657
rush change
Mar 23, 2018
d72d838
Delete the old rush change file
Mar 23, 2018
9d8c122
Remove a trailing space
Mar 23, 2018
0d2f2ca
Merge branch 'master' into stanleyy/fillin
Mar 26, 2018
421882b
Remove a redundant property from the ComboBox example
Mar 26, 2018
824ebf6
rush chagne
Mar 26, 2018
6a78413
Remove old rush change file
Mar 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/stanleyy-fillin_2018-03-26-22-09.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Remove a redundant property from the ComboBox example",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
5 changes: 3 additions & 2 deletions packages/office-ui-fabric-react/src/components/ComboBox/examples/ComboBox.Basic.Example.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@ export class ComboBoxBasicExample extends React.Component<{}, {
allowFreeform={ true }
autoComplete='on'
options={ optionsMulti }
value={ valueMulti }
onChanged={ this._onChangedMulti }
onResolveOptions={ this._getOptionsMulti }
onRenderOption={ this._onRenderFontOption }
Expand Down Expand Up @@ -336,7 +335,7 @@ export class ComboBoxBasicExample extends React.Component<{}, {

private _getOptionsMulti = (currentOptions: IComboBoxOption[]): IComboBoxOption[] => {

if (this.state.options.length > 0) {
if (this.state.optionsMulti.length > 0) {
return this.state.optionsMulti;
}

Expand All @@ -350,6 +349,7 @@ export class ComboBoxBasicExample extends React.Component<{}, {
}

private _onChanged = (option: IComboBoxOption, index: number, value: string): void => {
console.log('_onChanged() is called: option = ' + JSON.stringify(option));
if (option !== undefined) {
this.setState({
selectedOptionKey: option.key,
Expand All @@ -372,6 +372,7 @@ export class ComboBoxBasicExample extends React.Component<{}, {
}

private _onChangedMulti = (option: IComboBoxOption, index: number, value: string) => {
console.log('_onChangedMulti() is called: option = ' + JSON.stringify(option));
if (option !== undefined) {
// User selected/de-selected an existing option
this.setState({
Expand Down