Skip to content

In Panel component, isClickableOutsideFocusTrap should not be overriden back to false if it's already set to true in focusTrapZoneProps. #4354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 2 commits into from
Mar 26, 2018
Merged

In Panel component, isClickableOutsideFocusTrap should not be overriden back to false if it's already set to true in focusTrapZoneProps. #4354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c39f8df
In Panel, a true value of isClickableOutsideFocusTrap prop in focusTr…
Mar 23, 2018
f032ca1
Add change file.
Mar 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/master_2018-03-23-22-38.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "In Panel component, isClickableOutsideFocusTrap should not be overriden back to false if it's already set to true in focusTrapZoneProps.",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
4 changes: 3 additions & 1 deletion packages/office-ui-fabric-react/src/components/Panel/Panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,9 @@ export class Panel extends BaseComponent<IPanelProps, IPanelState> implements IP
) }
style={ customWidthStyles }
elementToFocusOnDismiss={ elementToFocusOnDismiss }
isClickableOutsideFocusTrap={ isLightDismiss || isHiddenOnDismiss }
isClickableOutsideFocusTrap={
isLightDismiss || isHiddenOnDismiss || (focusTrapZoneProps && focusTrapZoneProps.isClickableOutsideFocusTrap)
}
>
<div className={ css('ms-Panel-commands') } data-is-visible={ true } >
{ onRenderNavigation(renderProps, this._onRenderNavigation) }
Expand Down