Skip to content

DetailsHeader: reverting maxWidth behavior to previous. #4352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erichdev merged 2 commits into from
Mar 24, 2018
Merged

DetailsHeader: reverting maxWidth behavior to previous. #4352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
940a0b1
Reverting DetailsHeader maxWidth handling to previous behavior.
dzearing Mar 23, 2018
316f659
Adding change file.
dzearing Mar 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/detailsheader_2018-03-23-21-41.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "DetailsHeader: reverting how maxWidth is handled to previous behavior.",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "dzearing@microsoft.com"
}
4 changes: 2 additions & 2 deletions packages/office-ui-fabric-react/src/components/DetailsList/DetailsHeader.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ describe('DetailsHeader', () => {
header._onSizerMouseMove({ clientX: 100 });
expect(lastResize).toEqual({ index: 0, size: 300 });

// Mouse move 300 pixels to the right (should be capped at 400px width
// Mouse move 300 pixels to the right, should be 500.
header._onSizerMouseMove({ clientX: 300 });
expect(lastResize).toEqual({ index: 0, size: 400 });
expect(lastResize).toEqual({ index: 0, size: 500 });

// Complete sizing.
header._onSizerMouseUp();
Expand Down
7 changes: 2 additions & 5 deletions packages/office-ui-fabric-react/src/components/DetailsList/DetailsHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,12 +514,9 @@ export class DetailsHeader extends BaseComponent<IDetailsHeaderProps, IDetailsHe
movement = -movement;
}

const column = columns[columnResizeDetails!.columnIndex];
const requestedSize = columnResizeDetails!.columnMinWidth + movement;

onColumnResized(
column,
!!column.maxWidth ? Math.min(column.maxWidth, requestedSize) : requestedSize,
columns[columnResizeDetails!.columnIndex],
columnResizeDetails!.columnMinWidth + movement,
columnResizeDetails!.columnIndex
);
}
Expand Down