Skip to content

Fix bug in combo box where _selectedElement ref wasn't being set conditionally #4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jspurlin merged 3 commits into from
Mar 23, 2018
Merged

Fix bug in combo box where _selectedElement ref wasn't being set conditionally #4350

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe85326
Fix bug in combo box where _selectedElement ref wasn't being set cond…
kelseyyoung Mar 23, 2018
9f1e51c
Add rush change file
kelseyyoung Mar 23, 2018
56c2cb6
Use undefined instead of an empty string for the ref
kelseyyoung Mar 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .../changes/office-ui-fabric-react/keyou-fix-combobox-scrolling-to-end_2018-03-23-19-17.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Fix bug in combo box where _selectedElement ref wasn't being set conditionally",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "keyou@microsoft.com"
}
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/ComboBox/ComboBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,7 +1042,7 @@ export class ComboBox extends BaseComponent<IComboBoxProps, IComboBoxState> {
aria-selected={ isSelected ? 'true' : 'false'}
ariaLabel= {item.text }
disabled={ item.disabled }
> { <span ref={ this._selectedElement }>
> { <span ref={ isSelected ? this._selectedElement : '' }>

@Markionium Markionium Mar 23, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're trying to move away from string refs perhaps pass a noop?

const noop = () => {};

...

> { <span ref={ isSelected ? this._selectedElement : noop }>

@kelseyyoung kelseyyoung Mar 23, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about undefined? TSLint won't pass with an empty function block

@jspurlin jspurlin Mar 23, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think undefined would be fine, you may need to update the declaration to allow for undefined

@kelseyyoung kelseyyoung Mar 23, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine as is, ref is already an optional prop and passing undefined should just make it not set to anything. I'll push that in a minute

{ onRenderOption(item, this._onRenderOptionContent) }
</span>
}
Expand Down