Skip to content

Users/demarcey/cm icon hc #4311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmarcey merged 3 commits into from
Mar 19, 2018
Merged

Users/demarcey/cm icon hc #4311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0fbe2cd
Fix ContextualMenuItem Icon High Contrast colors.
dmarcey Mar 19, 2018
030fad9
Added change file.
dmarcey Mar 19, 2018
31e24e2
Turned " into '.
dmarcey Mar 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/users-demarcey-cmIconHC_2018-03-19-19-04.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Fixed bug with HC colors in icons in menus.",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "demarcey@microsoft.com"
}
16 changes: 15 additions & 1 deletion packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,21 @@ export const getMenuItemStyles = memoizeFunction((
color: semanticColors.menuIcon,
selectors: {
[HighContrastSelector]: {
color: 'HighlightText',
color: 'inherit',
},
['$root:hover &']: {
selectors: {
[HighContrastSelector]: {
color: 'HighlightText'
}
}
},
['$root:focus &']: {
selectors: {
[HighContrastSelector]: {
color: 'HighlightText'
}
}
}
}
},
Expand Down