Skip to content

Do not try to show the suggestions when input is undefined (no more exceptions in IE) #4294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 3 commits into from
Mar 27, 2018
Merged

Do not try to show the suggestions when input is undefined (no more exceptions in IE) #4294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17e0dda
[BasePicker] suggestions should not be shown when input does not exist
mbratukha Mar 16, 2018
5f37aa3
added change file
mbratukha Mar 16, 2018
8532dda
Update master_2018-03-16-09-03.json
dzearing Mar 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/master_2018-03-16-09-03.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "BasePicker: suggestions should not be shown in BasePicker when input does not exist.",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "bratukha.m@gmail.com"
}
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ export class BasePicker<T, P extends IBasePickerProps<T>> extends BaseComponent<

protected renderSuggestions(): JSX.Element | null {
const TypedSuggestion = this.SuggestionOfProperType;
return this.state.suggestionsVisible ? (
return this.state.suggestionsVisible && this.input ? (
<Callout
isBeakVisible={ false }
gapSpace={ 5 }
Expand Down