ContextualMenu: icons in high contrast mode#4263
Closed
lynamemi wants to merge 2 commits intomicrosoft:masterfrom
Closed
ContextualMenu: icons in high contrast mode#4263lynamemi wants to merge 2 commits intomicrosoft:masterfrom
lynamemi wants to merge 2 commits intomicrosoft:masterfrom
Conversation
Collaborator
Author
|
Closing this because another fix has since been merged: #4311 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Icons weren't showing up in high contrast mode. I moved styling to the 'root' item so that it works for item hover, etc, also.
Focus areas to test
(optional)