-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Theme generator: show in the website main nav #4251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ac3909a
Unhide theme generator
lynamemi ff4a0ad
Syncing theme gen page style to other pages
lynamemi b0fc0c5
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
lynamemi a0f2934
url editing
lynamemi a99de6d
No dash in urls
lynamemi dfa806b
Added references to the theme generator page
lynamemi 4f27327
Unhide from main nav, link edits
lynamemi 39b6507
Removed comma
lynamemi 700f727
Added change files
lynamemi ca0f5cb
removed pageStyles, wasn't doing much
lynamemi e67cb3d
Fixing brand-icons url
lynamemi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 28 additions & 2 deletions
30
apps/fabric-website/src/pages/Styles/ThemeGeneratorToolPage/ThemeGeneratorToolPage.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
common/changes/@uifabric/fabric-website/show-theme-generator_2018-03-13-16-46.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@uifabric/fabric-website", | ||
| "comment": "Theme generator: exposing to the website.", | ||
| "type": "minor" | ||
| } | ||
| ], | ||
| "packageName": "@uifabric/fabric-website", | ||
| "email": "[email protected]" | ||
| } |
11 changes: 11 additions & 0 deletions
11
common/changes/office-ui-fabric-react/show-theme-generator_2018-03-13-16-46.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "office-ui-fabric-react", | ||
| "comment": "Theme generator: exposing to the website.", | ||
| "type": "patch" | ||
| } | ||
| ], | ||
| "packageName": "office-ui-fabric-react", | ||
| "email": "[email protected]" | ||
| } |
111 changes: 57 additions & 54 deletions
111
packages/office-ui-fabric-react/src/components/ThemeGenerator/ThemeGeneratorPage.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,70 +1,73 @@ | ||
| @import '../../common/common'; | ||
| :global { | ||
|
|
||
| .ms-themer { | ||
| padding: 12px; | ||
| h2, h3, h4 { | ||
| color: $ms-color-black; | ||
| .overview .themeGeneratorPageLink { | ||
| color: $ms-color-themePrimary; | ||
| } | ||
| } | ||
| .ms-themer h3 { | ||
| margin: 0; | ||
| } | ||
|
|
||
| .ms-themer-paletteSlot { | ||
| text-align: center; | ||
| padding: 16px; | ||
| } | ||
| .ms-themer { | ||
| padding: 12px; | ||
| h2, h3, h4 { | ||
| color: $ms-color-black; | ||
| } | ||
| } | ||
| .ms-themer h3 { | ||
| margin: 0; | ||
| } | ||
|
|
||
| .ms-themer-swatch { | ||
| display: inline-block; | ||
| flex-shrink: 0; | ||
| height: 36px; | ||
| width: 36px; | ||
| margin: 4px; | ||
| } | ||
| .ms-themer-paletteSlot { | ||
| text-align: center; | ||
| padding: 16px; | ||
| } | ||
|
|
||
| .ms-themer-swatchBg { | ||
| padding: 4px; | ||
| font-size: 0; | ||
| .ms-themer-swatch { | ||
| height: 28px; | ||
| width: 28px; | ||
| margin: 2px; | ||
| display: inline-block; | ||
| flex-shrink: 0; | ||
| height: 36px; | ||
| width: 36px; | ||
| margin: 4px; | ||
| } | ||
| } | ||
|
|
||
| .ms-themer-example { | ||
| padding: 20px; | ||
| max-width: 40%; | ||
| } | ||
| .ms-themer-swatchBg { | ||
| padding: 4px; | ||
| font-size: 0; | ||
| .ms-themer-swatch { | ||
| height: 28px; | ||
| width: 28px; | ||
| margin: 2px; | ||
| } | ||
| } | ||
|
|
||
| .ms-themer-fabricPalette-root { | ||
| display: flex; | ||
| > div { | ||
| padding-left: 20px; | ||
| .ms-themer-example { | ||
| padding: 20px; | ||
| max-width: 40%; | ||
| } | ||
| } | ||
|
|
||
| .ms-themer-accessibilityTable td { | ||
| padding: 4px; | ||
| text-align: center; | ||
| } | ||
| .ms-themer-fabricPalette-root { | ||
| display: flex; | ||
| > div { | ||
| padding-left: 20px; | ||
| } | ||
| } | ||
|
|
||
| .ms-themer-accessibilityTable td { | ||
| padding: 4px; | ||
| text-align: center; | ||
| } | ||
|
|
||
| .ms-themer-slot { | ||
| display: flex; | ||
| align-items: center; | ||
| overflow: auto; | ||
| } | ||
| .ms-themer-slot { | ||
| display: flex; | ||
| align-items: center; | ||
| overflow: auto; | ||
| } | ||
|
|
||
| .ms-themer-output-root { | ||
| display: flex; | ||
| textarea { | ||
| height: 400px; | ||
| width: 280px; | ||
| margin-right: 28px; | ||
| background-color: white; | ||
| color: #333; | ||
| .ms-themer-output-root { | ||
| display: flex; | ||
| textarea { | ||
| height: 400px; | ||
| width: 280px; | ||
| margin-right: 28px; | ||
| background-color: white; | ||
| color: #333; | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true anymore? I thought we removed all the helper classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You tell me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this blurb refers to Fabric Core which definitely still has these classes.