Skip to content

Addressing Issue #4176 - Datepicker add is-open css class #4239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johannao76 merged 3 commits into from
Mar 12, 2018
Merged

Addressing Issue #4176 - Datepicker add is-open css class #4239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
949700f
Added is-open class to DatePicker root element based on state isDateP…
oengusmacinog-zz Mar 12, 2018
44af205
rush change
oengusmacinog-zz Mar 12, 2018
7f71218
fix jsx syntax
oengusmacinog-zz Mar 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/datepicker-isopen-4176_2018-03-12-18-20.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Added an is-open class to the DatePicker root element to indicate when the datepicker is being shown based on the IDatePickerState.isDatePickerShown state property.",
"type": "minor"
}
],
"packageName": "office-ui-fabric-react",
"email": "v-brgarl@microsoft.com"
}
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/DatePicker/DatePicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ export class DatePicker extends BaseComponent<IDatePickerProps, IDatePickerState
const { isDatePickerShown, formattedDate, selectedDate, errorMessage } = this.state;

return (
<div className={ css('ms-DatePicker', styles.root, className) }>
<div className={ css('ms-DatePicker', styles.root, isDatePickerShown && 'is-open', className) }>
{ label && (
<Label required={ isRequired }>{ label }</Label>
) }
Expand Down