Addressing Issue #531 - Documentation: Components should indicate if they take native props #4215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rd, Icon, and Image
…rsona, PivotItem, ResizeGroup, ScrollablePane, TextField, Toggle, and Tooltip
oengusmacinog-zz
requested review from
Jahnp,
atneik,
cschleiden,
micahgodbolt and
phkuo
as code owners
jordandrako
approved these changes
Mar 8, 2018
Member
|
Gave some feedback in person around the content of the message. This is a great change--really appreciate the clarity this adds. |
…ent and applied to Fabric components
micahgodbolt
approved these changes
Mar 12, 2018
Member
micahgodbolt
left a comment
micahgodbolt
left a comment
There was a problem hiding this comment.
Loving all the improvements to documentation. 80% of the feedback I get about why people chose fabric is because of our amazing documentation. Keep it up!
phkuo
reviewed
Mar 12, 2018
| if (this.props.allowNativeProps) { | ||
| let elementString: string | string[] | JSX.Element = this.props.nativePropsElement || 'div', | ||
| componentString: JSX.Element | undefined; | ||
| // componentString: JSX.Element = <> this component</>; |
phkuo
reviewed
Mar 12, 2018
| </ExampleCard> | ||
| </div> | ||
| } | ||
| allowNativeProps={ 'PivitItem' } |
phkuo
reviewed
Mar 12, 2018
| } | ||
|
|
||
| if (typeof this.props.allowNativeProps === 'string') { | ||
| // titleString = <> <code>{ this.props.allowNativeProps }</code></>; |
cschleiden
approved these changes
Mar 12, 2018
phkuo
approved these changes
Mar 12, 2018
atneik
approved these changes
Mar 12, 2018
Jahnp
approved these changes
Mar 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Added a info MessageBar to indicate when native props can be used on a component: