Skip to content

Persona - Separated SCSS for Persona and PersonaCoin into Two Files #4200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtennoe merged 3 commits into from
Mar 7, 2018
Merged

Persona - Separated SCSS for Persona and PersonaCoin into Two Files #4200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c76c1c
seperated out Persona and PersonaCoin components' SCSS
oengusmacinog-zz Mar 6, 2018
5fd3210
rush change
oengusmacinog-zz Mar 7, 2018
d9ffe75
cleanup comment
oengusmacinog-zz Mar 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/persona-splitscss_2018-03-07-00-00.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Seperated the SCSS for Persona and Persona Coin components due to bloat when imported twice.",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "v-brgarl@microsoft.com"
}
136 changes: 0 additions & 136 deletions packages/office-ui-fabric-react/src/components/Persona/Persona.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,18 +63,6 @@ $ms-Persona-presenceBorder: 2px;
}
}

.imageArea {
position: relative;
text-align: center;
flex: 0 0 auto;
height: $ms-Persona-size48;
width: $ms-Persona-size48;

.image {
border: 0px;
}
}

//= Note: The doughboy placeholder is being deprecated.
// The initials color block (.ms-Persona-initials) will be used going forward
// as a fallback when the persona does not have an image.
Expand All @@ -88,39 +76,6 @@ $ms-Persona-presenceBorder: 2px;
z-index: $ms-zIndex-middle;
}

.initials {
border-radius: 50%;
color: $ms-color-white;
font-size: $ms-font-size-l;
font-weight: $ms-font-weight-regular;
line-height: 46px;
height: $ms-Persona-size48;

@include high-contrast {
border: 1px solid WindowText;
-ms-high-contrast-adjust: none;
color: WindowText;
box-sizing: border-box;
// Using important to override all of the more specific initialsIsColor rules
background-color: Window !important;
}
}

.image {
@include ms-margin-right(10px);
position: absolute;
top: 0;
@include ms-left(0);
width: 100%;
height: 100%;
border-radius: 50%;
perspective: 1px;
}

.image[src=""] {
display: none;
}

.presence {
background-color: $ms-color-presence-available;
position: absolute;
Expand Down Expand Up @@ -202,12 +157,6 @@ $ms-Persona-presenceBorder: 2px;
}

.rootIsSize10 {
.imageArea {
overflow: visible;
background: transparent;
height: 0;
width: 0;
}

.presence {
@include ms-right(auto);
Expand Down Expand Up @@ -241,14 +190,6 @@ $ms-Persona-presenceBorder: 2px;
}
}

.size10NoPresenceIcon {
font-size: 10px;
position: absolute;
top: 5px;
@include ms-right(auto);
@include ms-left(0);
}

//== Modifier: Size 10 Persona with read only state
//
// This variant includes a semicolon, and is
Expand All @@ -270,23 +211,12 @@ $ms-Persona-presenceBorder: 2px;
}

.rootIsSize16 {
.imageArea,
.image {
height: $ms-Persona-size16;
width: $ms-Persona-size16;
}

.placeholder {
font-size: 18px;
top: 4px;
}

.initials {
font-size: $ms-font-size-xs;
height: $ms-Persona-size16;
line-height: $ms-Persona-size16;
}

.presence {
height: $ms-Persona-presenceSize6;
width: $ms-Persona-presenceSize6;
Expand Down Expand Up @@ -315,23 +245,12 @@ $ms-Persona-presenceBorder: 2px;
}

.rootIsSize24 {
.imageArea,
.image {
height: $ms-Persona-size24;
width: $ms-Persona-size24;
}

.placeholder {
font-size: 18px;
top: 4px;
}

.initials {
font-size: $ms-font-size-xs;
height: $ms-Persona-size24;
line-height: $ms-Persona-size24;
}

.presence {
height: $ms-Persona-presenceSize8;
width: $ms-Persona-presenceSize8;
Expand Down Expand Up @@ -378,23 +297,12 @@ $ms-Persona-presenceBorder: 2px;
}

.rootIsSize28 {
.imageArea,
.image {
height: $ms-Persona-size28;
width: $ms-Persona-size28;
}

.placeholder {
font-size: 18px;
top: 4px;
}

.initials {
font-size: $ms-font-size-xs;
height: $ms-Persona-size28;
line-height: $ms-Persona-size28;
}

.presence {
height: $ms-Persona-presenceSize8;
width: $ms-Persona-presenceSize8;
Expand Down Expand Up @@ -442,23 +350,12 @@ $ms-Persona-presenceBorder: 2px;
}

.rootIsSize32 {
.imageArea,
.image {
height: $ms-Persona-size32;
width: $ms-Persona-size32;
}

.placeholder {
font-size: 28px;
top: 6px;
}

.initials {
font-size: $ms-font-size-m;
height: $ms-Persona-size32;
line-height: $ms-Persona-size32;
}

.presence {
height: $ms-Persona-presenceSize8;
width: $ms-Persona-presenceSize8;
Expand Down Expand Up @@ -496,23 +393,12 @@ $ms-Persona-presenceBorder: 2px;
}

.rootIsSize40 {
.imageArea,
.image {
height: $ms-Persona-size40;
width: $ms-Persona-size40;
}

.placeholder {
font-size: 38px;
top: 5px;
}

.initials {
font-size: $ms-font-size-m;
height: $ms-Persona-size40;
line-height: $ms-Persona-size40;
}

.primaryText {
font-size: $ms-font-size-m;
}
Expand All @@ -527,23 +413,12 @@ $ms-Persona-presenceBorder: 2px;
}

.rootIsSize72 {
.imageArea,
.image {
height: $ms-Persona-size72;
width: $ms-Persona-size72;
}

.placeholder {
font-size: 67px;
top: 10px;
}

.initials {
font-size: $ms-font-size-xxl;
height: $ms-Persona-size72;
line-height: 70px;
}

.presence {
height: $ms-Persona-presenceSize20;
width: $ms-Persona-presenceSize20;
Expand Down Expand Up @@ -576,23 +451,12 @@ $ms-Persona-presenceBorder: 2px;
}

.rootIsSize100 {
.imageArea,
.image {
height: $ms-Persona-size100;
width: $ms-Persona-size100;
}

.placeholder {
font-size: 95px;
top: 12px;
}

.initials {
font-size: $ms-font-size-su;
height: $ms-Persona-size100;
line-height: 96px;
}

.presence {
height: $ms-Persona-presenceSize28;
width: $ms-Persona-presenceSize28;
Expand Down
Loading