Skip to content

Website fix: Remove PureComponent #4186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 3 commits into from
Mar 6, 2018
Merged

Website fix: Remove PureComponent #4186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3183c22
Replaced PureComponent with Component
lynamemi Mar 6, 2018
3e008a4
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
lynamemi Mar 6, 2018
b072ffe
Added change file
lynamemi Mar 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@uifabric/experiments/remove-pureComponent_2018-03-06-00-33.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@uifabric/experiments",
"comment": "Replaced PureComponent with Component to appease website's UHF react version.",
"type": "patch"
}
],
"packageName": "@uifabric/experiments",
"email": "lynam.emily@gmail.com"
}
11 changes: 11 additions & 0 deletions common/changes/@uifabric/utilities/remove-pureComponent_2018-03-06-00-33.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@uifabric/utilities",
"comment": "Replaced PureComponent with Component to appease website's UHF react version.",
"type": "patch"
}
],
"packageName": "@uifabric/utilities",
"email": "lynam.emily@gmail.com"
}
2 changes: 1 addition & 1 deletion packages/experiments/src/components/StaticList/StaticList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { IStaticListProps } from './StaticList.types';

import * as stylesImport from './StaticList.scss';

export class StaticList<TItem extends IObjectWithKey> extends React.PureComponent<IStaticListProps<TItem>> {
export class StaticList<TItem extends IObjectWithKey> extends React.Component<IStaticListProps<TItem>> {
public render(): JSX.Element {
const {
className,
Expand Down
2 changes: 1 addition & 1 deletion packages/utilities/src/Context.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function provideContext<TContext, TProps>(
contextTypes: PropTypes.ValidationMap<TContext>,
mapPropsToContext: (props: TProps) => TContext
): React.ComponentType<TProps & React.Props<{}>> {
class Provider extends React.PureComponent<TProps> {
class Provider extends React.Component<TProps> {
public static readonly childContextTypes: PropTypes.ValidationMap<TContext> = contextTypes;

public getChildContext(): TContext {
Expand Down