Skip to content

Aria selected #4161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 3 commits into from
Mar 2, 2018
Merged

Aria selected #4161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22aa2f7
do not include aria-selected if selectionMode is SelectionMode.none
natalieethell Mar 2, 2018
733719a
change file
natalieethell Mar 2, 2018
2e504c9
Update aria-selected_2018-03-02-01-49.json
dzearing Mar 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/aria-selected_2018-03-02-01-49.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "DetailsList: only adding `aria-selected` when `selectionMode` is set to `none`.",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "naethell@microsoft.com"
}
3 changes: 2 additions & 1 deletion packages/office-ui-fabric-react/src/components/DetailsList/DetailsRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ export class DetailsRow extends BaseComponent<IDetailsRowProps, IDetailsRowState
const canSelect = selection.canSelectItem!(item);
const isContentUnselectable = selectionMode === SelectionMode.multiple;
const showCheckbox = selectionMode !== SelectionMode.none && checkboxVisibility !== CheckboxVisibility.hidden;
const ariaSelected = (selectionMode === SelectionMode.none) ? undefined : isSelected;

return (
<FocusZone
Expand Down Expand Up @@ -229,7 +230,7 @@ export class DetailsRow extends BaseComponent<IDetailsRowProps, IDetailsRowState
draggable={ isDraggable }
data-automationid='DetailsRow'
style={ { minWidth: viewport ? viewport.width : 0 } }
aria-selected={ isSelected }
aria-selected={ ariaSelected }
allowFocusRoot={ true }
>
{ showCheckbox && (
Expand Down