Skip to content

Addressing Issue #4147 - Nav Buttons have invalid aria-describedby value #4159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 2 commits into from
Mar 2, 2018
Merged

Addressing Issue #4147 - Nav Buttons have invalid aria-describedby value #4159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b199ad4
Switched ActionButton prop in Nav from description to ariaDescription
oengusmacinog-zz Mar 2, 2018
13012d7
rush change
oengusmacinog-zz Mar 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/nav-ariadescribedby-4147_2018-03-02-00-43.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Fixed aria-describedby bug causing it not to render properly",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "v-brgarl@microsoft.com"
}
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/Nav/Nav.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ export class NavBase extends BaseComponent<INavProps, INavState> implements INav
styles={ buttonStyles }
href={ link.url || (link.forceAnchor ? 'javascript:' : undefined) }
iconProps={ link.iconProps || { iconName: link.icon || '' } }
description={ link.title || link.name }
ariaDescription={ link.title || link.name }
onClick={ link.onClick ? this._onNavButtonLinkClicked.bind(this, link) : this._onNavAnchorLinkClicked.bind(this, link) }
title={ link.title || link.name }
target={ link.target }
Expand Down