Skip to content

Fix documentcard theming #4155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 3 commits into from
Mar 2, 2018
Merged

Fix documentcard theming #4155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9f1f14
make document card respect theme
joschect Mar 1, 2018
9aad776
adding change file
joschect Mar 1, 2018
bb6350a
use better button color
joschect Mar 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/fix-documentcard-theming_2018-03-01-22-47.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "DocumentCard: Change it to use set theme",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "joschect@microsoft.com"
}
4 changes: 2 additions & 2 deletions packages/office-ui-fabric-react/src/components/DocumentCard/DocumentCard.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ $ms-DocumentCardActions-verticalPadding: 4px;

:global(.ms-Button:hover) {
:global(.ms-Button-icon) {
color: #1174c3;
color: $buttonTextColor;
cursor: pointer;
}
}
Expand Down Expand Up @@ -162,7 +162,7 @@ $ms-DocumentCardActivity-personaTextGutter: 8px;
top: -1px;
right: -1px;
bottom: -1px;
border: 2px solid #fafafa; // Match the background of the card
border: 2px solid $ms-color-white; // Match the background of the card
Copy link
Copy Markdown
Contributor

@phkuo phkuo Mar 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the border?

Copy link
Copy Markdown
Contributor Author

@joschect joschect Mar 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know.

Copy link
Copy Markdown
Member

@dzearing dzearing Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be wise to keep a visible border if there was one.

Copy link
Copy Markdown
Member

@dzearing dzearing Mar 2, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neutralLighterAlt which is f8f8f8

border-radius: 50%;
}
}
Expand Down