ComboBox: Fixed input overlap rendering issue#4102
Merged
lynamemi merged 3 commits intomicrosoft:masterfrom Feb 27, 2018
Merged
ComboBox: Fixed input overlap rendering issue#4102lynamemi merged 3 commits intomicrosoft:masterfrom
lynamemi merged 3 commits intomicrosoft:masterfrom
Conversation
mikewheaton
approved these changes
Feb 27, 2018
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Feb 27, 2018
…c-react into polyfill-react-createRef * 'master' of https://github.com/OfficeDev/office-ui-fabric-react: ComboBox: Fixed input overlap rendering issue (microsoft#4102)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
The switch to border-box sizing made the input look like it was overlapping some of the ComboBox border at certain resolutions.
Input wasn't using its whole height, so I shorted it and adding some padding to center it. Test in HC also to make sure that still works as expected.
Focus areas to test
(optional)