Skip to content

[ColorRectangle, Sticky] Fixed null root refs #4099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lambertwang-zz merged 5 commits into from
Feb 27, 2018
Merged

[ColorRectangle, Sticky] Fixed null root refs #4099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b7dd6c
[ColorRectangle, Sticky] Fixed null root refs
lambertwang-zz Feb 26, 2018
c449bf3
Change files
lambertwang-zz Feb 26, 2018
96d1327
Update Sticky.tsx
dzearing Feb 27, 2018
43f2cea
Update magellan-fixNullRootRef_2018-02-26-22-26.json
lambertwang Feb 27, 2018
d65cffb
Update magellan-fixNullRootRef_2018-02-26-22-26.json
dzearing Feb 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/magellan-fixNullRootRef_2018-02-26-22-26.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "ColorPicker: internal ref issue was fixed, which lets colors be picked a little better.",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "law@microsoft.com"
}
4 changes: 2 additions & 2 deletions packages/office-ui-fabric-react/src/components/ColorPicker/ColorRectangle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export class ColorRectangle extends BaseComponent<IColorRectangleProps, IColorPi
minSize: 220
};

private root: HTMLDivElement;
private _root: HTMLDivElement;

constructor(props: IColorRectangleProps) {
super(props);
Expand Down Expand Up @@ -87,7 +87,7 @@ export class ColorRectangle extends BaseComponent<IColorRectangleProps, IColorPi
@autobind
private _onMouseMove(ev: React.MouseEvent<HTMLElement>) {
const { color, onSVChanged } = this.props;
const rectSize = this.root.getBoundingClientRect();
const rectSize = this._root.getBoundingClientRect();

const sPercentage = (ev.clientX - rectSize.left) / rectSize.width;
const vPercentage = (ev.clientY - rectSize.top) / rectSize.height;
Expand Down