ComboBox button should have data-is-focusable="false" #4070
Conversation
dzearing
changed the title
|
Yep. this holds true for spitButtons and spinButtons as well |
jspurlin
changed the title
|
@paterasMSFT The button should always be data-is-focusable={false}... it should never be focusable |
jspurlin
changed the title
…dified .snap file to reflect new value.
|
It occurs to me that if the button is no longer keyboard navigatable, should we also remove aria-hidden=true and tabindex=-1? Do those still serve a purpose? I know tabindex=-1 means it's not keyboard navigatable (something I surmise the FocusZone works around), but is still focusable (presumably by mouse?). |
|
just got your comment. Yes, the tabindex can be removed, but we should hold off on removing the aria-hidden, there's still some unresolved issues around how the comboBox gets build for accessibility where it currently doesn't correctly represent the control correctly if the button is visible |
|
Now that the PR is closed, how should I make that change? |
|
No, we can make that update when we deal with the unresolved issues that exist on the browser/screen reader side of things |
* master: (28 commits) Scrollable pane sort stickies (microsoft#4111) Allow ScrollablePane to accept native properties. (microsoft#4095) Sticky (microsoft#4091) Applying package updates. [ColorRectangle, Sticky] Fixed null root refs (microsoft#4099) DatePicker: order of callbacks for onSelectDate and onAfterMenuDismiss (microsoft#4092) Applying package updates. Alhenry fix split button props (microsoft#4090) Fixing ComboBox styling by reverting button classname move (microsoft#4088) Update CODEOWNERS Undoing terrible change. [DetailsList] Fixed focus test (microsoft#4087) Added icons package screener test (microsoft#4082) ContextualMenu: Fix ContextualMenuUtility imports (microsoft#4085) [ContextualMenu] Made disabled buttons focusable (microsoft#4074) Convert Check to mergeStyles (microsoft#3880) [DetailsList] Add public focusIndex function (microsoft#3852) ComboBox button should have data-is-focusable="false" (microsoft#4070) Applying package updates. Focus Zone: Allow Tab to Skip Selection (microsoft#4061) ...
3 participants
Pull request checklist
$ npm run changeDescription of changes
Added a property to ComboBox to specify the value for its button's data-is-focusable attribute. This is useful when the ComboBox is part of a FocusZone, as setting the value to false allows the button to be skipped with keyboard navigation.
I defaulted it to true, to avoid making a silent, subtle change for existing users. However, I believe the most frequent use case would be to set it to false, as that button doesn't make much sense in a keyboard navigation context. Any advice on what the appropriate default setting should be would be appreciated.