Skip to content

Enable no internal module #4059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 2 commits into from
Feb 21, 2018
Merged

Enable no internal module #4059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b20ebb5
Enable no-internal-module lint rule
Markionium Feb 21, 2018
1fdbcd2
Add npm change file
Markionium Feb 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/enable-no-internal-module_2018-02-21-21-40.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "",
"packageName": "office-ui-fabric-react",
"type": "none"
}
],
"packageName": "office-ui-fabric-react",
"email": "mark@thedutchies.com"
}
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/utilities/positioning/positioning.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const SLIDE_ANIMATIONS: { [key: number]: string; } = {
* Do not call methods from this directly, use either positionCallout or positionElement or make another function that
* utilizes them.
*/
export module positioningFunctions {
export namespace positioningFunctions {

export interface IElementPosition {
elementRectangle: Rectangle;
Expand Down
1 change: 0 additions & 1 deletion packages/office-ui-fabric-react/tslint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
],
"no-any": false,
"variable-name": false,
"no-internal-module": false,
"typedef": [
false
],
Expand Down