Skip to content

scrollable pane null ref check to resolve "Failed to execute 'getComputedStyle' on 'Window'" bug #4039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 8 commits into from
Feb 21, 2018
Merged

scrollable pane null ref check to resolve "Failed to execute 'getComputedStyle' on 'Window'" bug #4039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
be58d62
Checking this.refs.root for undefined before calling getComputedStyle…
Feb 20, 2018
6cadba7
adding change file
Feb 20, 2018
4dd0e1c
clarifying comment
Feb 20, 2018
6dae5d9
Cancelling timers during componentWillUnmount to avoid using unmounte…
Feb 21, 2018
bd01464
updating comment
Feb 21, 2018
cdc971c
Merge remote-tracking branch 'upstream/master' into davsm.scrollable-…
Feb 21, 2018
d01c455
updated to use _async.setTimeout
Feb 21, 2018
9c0fcd5
updating comment
Feb 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...changes/office-ui-fabric-react/davsm.scrollable-pane-null-ref-check_2018-02-20-22-39.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Fix Scrollable-Pane getComputedStyle error - changing timeouts to use this._async.setTimeout to ensure this.refs isn't used after componentWillUnmount",
"type": "minor"
}
],
"packageName": "office-ui-fabric-react",
"email": "davsm@microsoft.com"
}
6 changes: 3 additions & 3 deletions packages/office-ui-fabric-react/src/components/ScrollablePane/ScrollablePane.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export class ScrollablePaneBase extends BaseComponent<IScrollablePaneProps, {}>

this._events.on(root, 'scroll', this.notifySubscribers);
this._events.on(window, 'resize', this._onWindowResize);
setTimeout(() => {
this._async.setTimeout(() => {
this._resizeContainer();
if (stickyContainer.parentElement && root.parentElement) {
stickyContainer.parentElement.removeChild(stickyContainer);
Expand Down Expand Up @@ -171,7 +171,7 @@ export class ScrollablePaneBase extends BaseComponent<IScrollablePaneProps, {}>
this._setPlaceholderHeights.bind(null, stickyList),
false);
if (sticky.props.stickyClassName) {
setTimeout(() => {
this._async.setTimeout(() => {
if (sticky.props.stickyClassName) {
sticky.content.children[0].classList.add(sticky.props.stickyClassName);
}
Expand All @@ -191,7 +191,7 @@ export class ScrollablePaneBase extends BaseComponent<IScrollablePaneProps, {}>
}

private _onWindowResize() {
setTimeout(() => {
this._async.setTimeout(() => {
this._resizeContainer();
this.notifySubscribers();
this._setPlaceholderHeights(this._stickyAbove);
Expand Down