Skip to content

Features/disabled link pointer events #4020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 4 commits into from
Feb 21, 2018
Merged

Features/disabled link pointer events #4020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c6dd4b
Allow pointer events on diabled links used as buttons
hoovercj Feb 19, 2018
df0d682
Add change file
hoovercj Feb 19, 2018
f91d76b
Fix wording in change file
hoovercj Feb 19, 2018
3f58325
Update snapshot
hoovercj Feb 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...hanges/office-ui-fabric-react/features-disabled-link-pointer-events_2018-02-19-16-13.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"changes": [{
"packageName": "office-ui-fabric-react",
"comment": "Only apply 'pointer-events: none' to disabled Link components if there is an href ",
"type": "patch"
}],
"packageName": "office-ui-fabric-react",
"email": "cohoov@microsoft.com"
}
10 changes: 8 additions & 2 deletions packages/office-ui-fabric-react/src/components/Link/Link.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,14 @@ export const getStyles = (props: ILinkStyleProps): ILinkStyles => {
'is-disabled',
{
color: semanticColors.disabledText,
cursor: 'default',
pointerEvents: 'none'
cursor: 'default'
},
{
selectors: {
'&:link, &:visited': {
pointerEvents: 'none'
}
}
}
],
!isDisabled && {
Expand Down
8 changes: 6 additions & 2 deletions packages/office-ui-fabric-react/src/components/Link/__snapshots__/Link.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ exports[`Link renders disabled Link correctly 1`] = `
color: #a6a6a6;
cursor: default;
outline: transparent;
pointer-events: none;
position: relative;
text-decoration: none;
}
Expand All @@ -162,6 +161,9 @@ exports[`Link renders disabled Link correctly 1`] = `
top: 1px;
z-index: 1;
}
&:link, &:visited {
pointer-events: none;
}
href="#"
onClick={[Function]}
target={undefined}
Expand Down Expand Up @@ -193,7 +195,6 @@ exports[`Link renders disabled Link with no href as a button correctly 1`] = `
padding-left: 0px;
padding-right: 0px;
padding-top: 0px;
pointer-events: none;
position: relative;
text-align: left;
text-overflow: inherit;
Expand All @@ -215,6 +216,9 @@ exports[`Link renders disabled Link with no href as a button correctly 1`] = `
@media screen and (-ms-high-contrast: active){& {
color: Highlight;
}
&:link, &:visited {
pointer-events: none;
}
disabled={true}
onClick={[Function]}
>
Expand Down