-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Fix aria attributes in ContextualMenu and CommandBar #3951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| { renderedItems!.map((item, index) => ( | ||
| this._renderItemInCommandBar(item, index, expandedMenuItemKey!) | ||
| { renderedItems!.map(item => ( | ||
| this._renderItemInCommandBar(item, posInSet++, setSize, expandedMenuItemKey!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
posInSet [](start = 49, length = 8)
Can you please add another value to the snapshot tests such that the count increment is working correctly. Or a unit test would be equally good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you meant by "add another value to the snapshot tests such that the count increment is working correctly" so I added a unit test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works! But he just meant add another item in the items of the command bar in the snapshot unit test which is easier to at least validate in the snapshot that the setSize works. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks David!
|
Please merge master to make the screener tests pass |
manishgarg1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test fixes required
|
@manishgarg1 I am not sure the screener test failures are caused by my changes. I see the same failures in other runs. Edit: Never mind, I see I need to merge master. |
|
Spinning off screener tests again. If it fails unexpectedly, please remerge master. I think there are 2 issues; master was broken - this is now fixed. screener has a bug which will link "officedev/master" instead of "trevorsg/master" which is hiding what broke. I talked with screener devs, and they're fixing this! |
Pull request checklist
$ npm run changeDescription of changes
2 Bug fixes:
Focus areas to test
Unit test included for (1) above. Otherwise this is a low-risk change.