Skip to content

[TextField] fix validate function works with validate on focus out #3944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
manishgarg1 merged 4 commits into from
Feb 13, 2018
Merged

[TextField] fix validate function works with validate on focus out #3944

manishgarg1 merged 4 commits into from
Feb 13, 2018

Conversation

@IASamoylov
Copy link
Contributor

@IASamoylov IASamoylov commented Feb 11, 2018 •
edited
Loading

Pull request checklist

Description of changes

Fixed bug, when we re-enter incorrect value, the focus out/in validation will not be triggered, more information in issue #3940

  • fixed logic re-validate for attrivute validateOnFocusIn and validateOnFocusOut
  • changed tests

@IASamoylov IASamoylov changed the title Bugfix/fix validate function works with validate on focus out [TextField] Bugfix/fix validate function works with validate on focus out Feb 12, 2018
@IASamoylov IASamoylov changed the title [TextField] Bugfix/fix validate function works with validate on focus out [TextField] fix validate function works with validate on focus out Feb 12, 2018
manishgarg1
manishgarg1 suggested changes Feb 12, 2018
View reviewed changes
Copy link
Collaborator

@manishgarg1 manishgarg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@manishgarg1 manishgarg1 self-assigned this Feb 12, 2018
manishgarg1
manishgarg1 approved these changes Feb 13, 2018
View reviewed changes
Copy link
Collaborator

@manishgarg1 manishgarg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@manishgarg1 manishgarg1 merged commit ad1dcfc into microsoft:master Feb 13, 2018
@IASamoylov IASamoylov deleted the bugfix/Fix-validate-function-works-with-validateOnFocusOut branch February 14, 2018 02:13
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@manishgarg1 manishgarg1 manishgarg1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@manishgarg1 manishgarg1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[TextField] Validate function works incorrect with attribute "validateOnFocusOut"

2 participants

@IASamoylov @manishgarg1