Skip to content

Conversation

@Hugodol
Copy link
Contributor

@Hugodol Hugodol commented Feb 8, 2018

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • [ x] Include a change request file using $ npm run change

Description of changes

Added a prop to Searchbocx called clearButtonAriaLabel to add an aria-label to the clear search box button.

Focus areas to test

Added clearButtonAriaLabel to SearchBox.Small.Example for testing.

@msftclas
Copy link

msftclas commented Feb 8, 2018

CLA assistant check
All CLA requirements met.

@manishgarg1
Copy link
Collaborator

Hi @Hugodol, this (#3946) pull request is trying to achieve the same end goal. Would you be ok if we rejected your pull request and got the other to merge as his change is adding two aria props which you may also need?

@manishgarg1 manishgarg1 self-assigned this Feb 12, 2018
@manishgarg1
Copy link
Collaborator

Hi @Hugodol, this (#3946) pull request is already merged. It should solve your problem, please reactivate this pull request. thanx.

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants