Skip to content

Contextual Menu Item - Passing Extra Information For MenuItem OnRender #3878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jspurlin merged 7 commits into from
Feb 12, 2018
Merged

Contextual Menu Item - Passing Extra Information For MenuItem OnRender #3878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a4e12d6
added new aria types for contextual menu
Feb 3, 2018
eb6db7e
add change files
Feb 3, 2018
b9c1e84
added other passed in values
Feb 3, 2018
1085576
added all selector
Feb 8, 2018
c7da45a
used all prop selector; changes comments
Feb 8, 2018
2c5e4d5
removed reference to new posinset and setsize props
Feb 8, 2018
e9a8719
removed aray of aria set size for contextual menu
Feb 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/accContextualMenu_2018-02-03-00-25.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Contextual Menu - adding support for aria-setsize and aria-posinset for rendering menu items that relies on the menu item's own rendering",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ export class ContextualMenu extends BaseComponent<IContextualMenuProps, IContext

private _renderNormalItem(item: IContextualMenuItem, classNames: IMenuItemClassNames, index: number, focusableElementIndex: number, totalItemCount: number, hasCheckmarks: boolean, hasIcons: boolean): React.ReactNode {
if (item.onRender) {
return [item.onRender(item, this.dismiss)];
return [item.onRender({ 'aria-posinset': focusableElementIndex, 'aria-setsize': totalItemCount, ...item }, this.dismiss)];
}
if (item.href) {
return this._renderAnchorMenuItem(item, classNames, index, focusableElementIndex, totalItemCount, hasCheckmarks, hasIcons);
Expand Down