Skip to content

The size of a persona is not impacted by the presence indicator. #3845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 3 commits into from
Feb 12, 2018
Merged

The size of a persona is not impacted by the presence indicator. #3845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f5727a
PersonaCoin: presence does not influence layout
Jan 31, 2018
19874a5
commit change file
Jan 31, 2018
52e0d89
fix persona pill
Jan 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/master_2018-01-31-12-27.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "presence indicator does not influence layout of Persona",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "vibailly@microsoft.com"
}
34 changes: 15 additions & 19 deletions packages/office-ui-fabric-react/src/components/Persona/Persona.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ $ms-Persona-presenceBorder: 2px;
height: $ms-Persona-size48;
display: flex;
align-items: center;
overflow: hidden;

.contextualHost {
display: none;
Expand Down Expand Up @@ -202,7 +201,7 @@ $ms-Persona-presenceBorder: 2px;
min-width: $ms-Persona-size10;
}

.rootIsSize10{
.rootIsSize10 {
.imageArea {
overflow: visible;
background: transparent;
Expand Down Expand Up @@ -266,9 +265,8 @@ $ms-Persona-presenceBorder: 2px;
//== Modifier: Size 16 Persona
//
.root.rootIsSize16 {
height: $ms-Persona-size16 + $ms-Persona-presenceBorder;
min-width: $ms-Persona-size16 + $ms-Persona-presenceBorder;
overflow: hidden;
height: $ms-Persona-size16;
min-width: $ms-Persona-size16;
}

.rootIsSize16 {
Expand Down Expand Up @@ -312,8 +310,8 @@ $ms-Persona-presenceBorder: 2px;
//== Modifier: Size 24 Persona
//
.root.rootIsSize24 {
height: $ms-Persona-size24 + $ms-Persona-presenceBorder;
min-width: $ms-Persona-size24 + $ms-Persona-presenceBorder;
height: $ms-Persona-size24;
min-width: $ms-Persona-size24;
}

.rootIsSize24 {
Expand Down Expand Up @@ -372,13 +370,11 @@ $ms-Persona-presenceBorder: 2px;
}
}


//== Modifier: Size 28 Persona
//
.root.rootIsSize28 {
height: $ms-Persona-size28 + $ms-Persona-presenceBorder;
min-width: $ms-Persona-size28 + $ms-Persona-presenceBorder;
overflow: hidden;
height: $ms-Persona-size28;
min-width: $ms-Persona-size28;
}

.rootIsSize28 {
Expand Down Expand Up @@ -441,8 +437,8 @@ $ms-Persona-presenceBorder: 2px;
//== Modifier: Size 32 Persona
//
.root.rootIsSize32 {
height: $ms-Persona-size32 + $ms-Persona-presenceBorder;
min-width: $ms-Persona-size32 + $ms-Persona-presenceBorder;
height: $ms-Persona-size32;
min-width: $ms-Persona-size32;
}

.rootIsSize32 {
Expand Down Expand Up @@ -495,8 +491,8 @@ $ms-Persona-presenceBorder: 2px;
//== Modifier: Size 40 Persona
//
.root.rootIsSize40 {
height: $ms-Persona-size40 + $ms-Persona-presenceBorder;
min-width: $ms-Persona-size40 + $ms-Persona-presenceBorder;
height: $ms-Persona-size40;
min-width: $ms-Persona-size40;
}

.rootIsSize40 {
Expand Down Expand Up @@ -526,8 +522,8 @@ $ms-Persona-presenceBorder: 2px;
//== Modifier: Size 72 Persona
//
.root.rootIsSize72 {
height: $ms-Persona-size72 + $ms-Persona-presenceBorder;
min-width: $ms-Persona-size72 + $ms-Persona-presenceBorder;
height: $ms-Persona-size72;
min-width: $ms-Persona-size72;
}

.rootIsSize72 {
Expand Down Expand Up @@ -575,8 +571,8 @@ $ms-Persona-presenceBorder: 2px;
//== Modifier: Size 100 Persona
//
.root.rootIsSize100 {
height: $ms-Persona-size100 + $ms-Persona-presenceBorder;
min-width: $ms-Persona-size100 + $ms-Persona-presenceBorder;
height: $ms-Persona-size100;
min-width: $ms-Persona-size100;
}

.rootIsSize100 {
Expand Down
6 changes: 4 additions & 2 deletions ...abric-react/src/components/pickers/PeoplePicker/PeoplePickerItems/PickerItemsDefault.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,11 @@
flex: 0 1 auto;
min-width: 0px;

/** CSS below is needed for IE 11 to properly truncate long persona names in the picker **/
/** CSS below is needed for IE 11 to properly truncate long persona names in the picker
** and to clip the presence indicator (in all browsers)
**/
max-width: 100%;
overflow-x: hidden;
overflow: hidden;
Copy link
Collaborator

@lynamemi lynamemi Feb 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this line is what's blocking in screener. Is there another way to accomplish what you need here?

}

.removeButton {
Expand Down