Moves label outside of DatePicker hit target #3832
Conversation
|
Specifically, this bug fix is required for a new search feature in OWA. Thanks, guys! |
|
@johannao76 is this something someone on your team can take a look at? |
|
Also, @martellaj, can you take a look at Travis and see why this is failing build. |
|
@micahgodbolt The failures looked unrelated. I'm rerunning it for the 3 repos it failed on to see if it's consistent. |
|
@micahgodbolt All the failures seem like they're set up related. Is there someone who understands the CI builds more that can take a look? |
|
/home/travis/build/OfficeDev/office-ui-fabric-react/packages/office-ui-fabric-react/src/components/DatePicker/DatePicker.tsx ERROR: 14:23 quotemark " should be ' Just a linting error it seems. |
| import { Callout } from '../../Callout'; | ||
| import { DirectionalHint } from '../../common/DirectionalHint'; | ||
| import { TextField } from '../../TextField'; | ||
| import { Label } from "../../Label"; |
|
@micahgodbolt, @dzearing, @lorejoh12, @johannao76 - I've worked out the build issues and test issues and now have all the checks passing. Can someone please review so I can get this checked in? Thank you! |
|
Ping... this a 4 line code change. Can one of the required reviwers (@johannao76 / @lorejoh12) please review? |
|
Ping... @johannao76, @lorejoh12 - can someone please take a look? It's been 2 weeks without review from a required reviewer. Thanks! |
|
sorry about the delay, looking at it |
4 participants
Pull request checklist
$ npm run changeDescription of changes
Moves label outside of hit target so that user can click outside the
TextFieldand dismiss theDatePicker. This is particularly useful in cases where theDatePickeris rendered in a small area and there's not much space around it for the user to click out and dismiss it.