Skip to content

Fix an issue in IE11 where focus outline was not visible in BaseButton component #3807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mohitbagra wants to merge 4 commits into from
Closed

Fix an issue in IE11 where focus outline was not visible in BaseButton component #3807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d92708
fix invisibile focus outline in baseButton in IE11
Jan 25, 2018
e4c86bd
add change file
Jan 25, 2018
cf1f397
commit updated snapshot files
Jan 26, 2018
a90cec7
commit one more snap file
Jan 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...n/changes/office-ui-fabric-react/mbagra-fixfocusoutlinebasebuttonIE_2018-01-25-18-57.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Fix an issue in IE11 where focus outline was not visible in BaseButton component",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
16 changes: 8 additions & 8 deletions packages/experiments/src/components/CommandBar/__snapshots__/CommandBar.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,13 @@ exports[`CommandBar renders commands correctly 1`] = `
}
.ms-Fabric.is-focusVisible &:focus:after {
border: 1px solid #ffffff;
bottom: 0px;
bottom: 1px;
content: "";
left: 0px;
left: 1px;
outline: 1px solid #666666;
position: absolute;
right: 0px;
top: 0px;
right: 1px;
top: 1px;
z-index: 1;
}
&:hover {
Expand Down Expand Up @@ -181,13 +181,13 @@ exports[`CommandBar renders commands correctly 1`] = `
}
.ms-Fabric.is-focusVisible &:focus:after {
border: 1px solid #ffffff;
bottom: 0px;
bottom: 1px;
content: "";
left: 0px;
left: 1px;
outline: 1px solid #666666;
position: absolute;
right: 0px;
top: 0px;
right: 1px;
top: 1px;
z-index: 1;
}
&:hover {
Expand Down
8 changes: 4 additions & 4 deletions ...s/office-ui-fabric-react/src/components/Breadcrumb/__snapshots__/Breadcrumb.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,13 +218,13 @@ exports[`Breadcrumb renders breadcumb correctly 2`] = `
}
.ms-Fabric.is-focusVisible &:focus:after {
border: 1px solid #ffffff;
bottom: 0px;
bottom: 1px;
content: "";
left: 0px;
left: 1px;
outline: 1px solid #666666;
position: absolute;
right: 0px;
top: 0px;
right: 1px;
top: 1px;
z-index: 1;
}
&:hover {
Expand Down
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/Button/BaseButton.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export const getStyles = memoizeFunction((

return {
root: [
getFocusStyle(theme, -1),
getFocusStyle(theme, 0),
theme.fonts.medium,
{
boxSizing: 'border-box',
Expand Down
40 changes: 20 additions & 20 deletions packages/office-ui-fabric-react/src/components/Button/__snapshots__/Button.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,13 @@ exports[`Button renders ActionButton correctly 1`] = `
}
.ms-Fabric.is-focusVisible &:focus:after {
border: 1px solid #ffffff;
bottom: 0px;
bottom: 1px;
content: "";
left: 0px;
left: 1px;
outline: 1px solid #666666;
position: absolute;
right: 0px;
top: 0px;
right: 1px;
top: 1px;
z-index: 1;
}
&:hover {
Expand Down Expand Up @@ -144,13 +144,13 @@ exports[`Button renders CommandBarButton correctly 1`] = `
}
.ms-Fabric.is-focusVisible &:focus:after {
border: 1px solid #ffffff;
bottom: 0px;
bottom: 1px;
content: "";
left: 0px;
left: 1px;
outline: 1px solid #666666;
position: absolute;
right: 0px;
top: 0px;
right: 1px;
top: 1px;
z-index: 1;
}
&:hover {
Expand Down Expand Up @@ -294,13 +294,13 @@ exports[`Button renders CompoundButton correctly 1`] = `
}
.ms-Fabric.is-focusVisible &:focus:after {
border: 1px solid #ffffff;
bottom: 0px;
bottom: 1px;
content: "";
left: 0px;
left: 1px;
outline: 1px solid #666666;
position: absolute;
right: 0px;
top: 0px;
right: 1px;
top: 1px;
z-index: 1;
}
&:hover {
Expand Down Expand Up @@ -422,13 +422,13 @@ exports[`Button renders DefaultButton correctly 1`] = `
}
.ms-Fabric.is-focusVisible &:focus:after {
border: 1px solid #ffffff;
bottom: 0px;
bottom: 1px;
content: "";
left: 0px;
left: 1px;
outline: 1px solid #666666;
position: absolute;
right: 0px;
top: 0px;
right: 1px;
top: 1px;
z-index: 1;
}
&:hover {
Expand Down Expand Up @@ -520,13 +520,13 @@ exports[`Button renders IconButton correctly 1`] = `
}
.ms-Fabric.is-focusVisible &:focus:after {
border: 1px solid #ffffff;
bottom: 0px;
bottom: 1px;
content: "";
left: 0px;
left: 1px;
outline: 1px solid #666666;
position: absolute;
right: 0px;
top: 0px;
right: 1px;
top: 1px;
z-index: 1;
}
&:hover {
Expand Down
8 changes: 4 additions & 4 deletions packages/office-ui-fabric-react/src/components/ComboBox/__snapshots__/ComboBox.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,13 +160,13 @@ exports[`ComboBox Renders ComboBox correctly 1`] = `
}
.ms-Fabric.is-focusVisible &:focus:after {
border: 1px solid #ffffff;
bottom: 0px;
bottom: 1px;
content: "";
left: 0px;
left: 1px;
outline: 1px solid #666666;
position: absolute;
right: 0px;
top: 0px;
right: 1px;
top: 1px;
z-index: 1;
}
@media screen and (-ms-high-contrast: active){& {
Expand Down
8 changes: 4 additions & 4 deletions packages/office-ui-fabric-react/src/components/Facepile/__snapshots__/Facepile.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,13 @@ exports[`Facepile renders Facepile correctly 1`] = `
}
.ms-Fabric.is-focusVisible &:focus:after {
border: 1px solid #ffffff;
bottom: 0px;
bottom: 1px;
content: "";
left: 0px;
left: 1px;
outline: 1px solid #666666;
position: absolute;
right: 0px;
top: 0px;
right: 1px;
top: 1px;
z-index: 1;
}
data="75%"
Expand Down
8 changes: 4 additions & 4 deletions packages/office-ui-fabric-react/src/components/Nav/__snapshots__/Nav.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,13 @@ exports[`Nav renders Nav correctly 1`] = `
}
.ms-Fabric.is-focusVisible &:focus:after {
border: 1px solid #ffffff;
bottom: 0px;
bottom: 1px;
content: "";
left: 0px;
left: 1px;
outline: 1px solid #666666;
position: absolute;
right: 0px;
top: 0px;
right: 1px;
top: 1px;
z-index: 1;
}
&:hover {
Expand Down
16 changes: 8 additions & 8 deletions packages/office-ui-fabric-react/src/components/Pivot/__snapshots__/Pivot.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,13 @@ exports[`Pivot renders Pivot correctly 1`] = `
}
.ms-Fabric.is-focusVisible &:focus:after {
border: 1px solid #ffffff;
bottom: 0px;
bottom: 1px;
content: "";
left: 0px;
left: 1px;
outline: 1px solid #666666;
position: absolute;
right: 0px;
top: 0px;
right: 1px;
top: 1px;
z-index: 1;
}
&:hover {
Expand Down Expand Up @@ -152,13 +152,13 @@ exports[`Pivot renders Pivot correctly 1`] = `
}
.ms-Fabric.is-focusVisible &:focus:after {
border: 1px solid #ffffff;
bottom: 0px;
bottom: 1px;
content: "";
left: 0px;
left: 1px;
outline: 1px solid #666666;
position: absolute;
right: 0px;
top: 0px;
right: 1px;
top: 1px;
z-index: 1;
}
&:hover {
Expand Down
16 changes: 8 additions & 8 deletions ...s/office-ui-fabric-react/src/components/SpinButton/__snapshots__/SpinButton.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,13 +185,13 @@ exports[`SpinButton renders SpinButton correctly 1`] = `
}
.ms-Fabric.is-focusVisible &:focus:after {
border: 1px solid #ffffff;
bottom: 0px;
bottom: 1px;
content: "";
left: 0px;
left: 1px;
outline: 1px solid #666666;
position: absolute;
right: 0px;
top: 0px;
right: 1px;
top: 1px;
z-index: 1;
}
&:hover {
Expand Down Expand Up @@ -291,13 +291,13 @@ exports[`SpinButton renders SpinButton correctly 1`] = `
}
.ms-Fabric.is-focusVisible &:focus:after {
border: 1px solid #ffffff;
bottom: 0px;
bottom: 1px;
content: "";
left: 0px;
left: 1px;
outline: 1px solid #666666;
position: absolute;
right: 0px;
top: 0px;
right: 1px;
top: 1px;
z-index: 1;
}
&:hover {
Expand Down
Loading