-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[TextField] Implemented masking #3783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
251e839
71cea3f
4bf0059
ab1c2c7
cfd5e0a
c61c77c
b932927
e2462f0
257ea8a
86e3260
76c3d1b
322141d
7ae09a0
794d948
2ac854f
17cff11
b66bdb9
3ea706d
218637f
fc57283
ed138ae
f47a481
1cfbdf7
7060aee
5eb7615
7776a30
ade5b57
41353cd
ef1e721
ed03b12
5087641
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "office-ui-fabric-react", | ||
| "comment": "[TextField] Inmplemented Input Masking", | ||
| "type": "minor" | ||
| } | ||
| ], | ||
| "packageName": "office-ui-fabric-react", | ||
| "email": "law@microsoft.com" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| /* tslint:disable:no-unused-variable */ | ||
| import * as React from 'react'; | ||
| /* tslint:enable:no-unused-variable */ | ||
| import { TextField } from 'office-ui-fabric-react/lib/TextField'; | ||
| import { DefaultTextField } from 'office-ui-fabric-react/lib/TextField'; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do you change all of the examples to use
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For the same reason all of the Button examples were changed to use
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What about compat, when I use TextField today, will I have to change to DefaultTextfield with this change?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, just as with button, the
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @lambertwang I don't really think that's a good idea. |
||
| import { | ||
| DetailsList, | ||
| DetailsListLayoutMode, | ||
|
|
@@ -71,7 +71,7 @@ export class DetailsListCompactExample extends React.Component<{}, { | |
| return ( | ||
| <div> | ||
| <div>{ selectionDetails }</div> | ||
| <TextField | ||
| <DefaultTextField | ||
| label='Filter by name:' | ||
| onChanged={ this._onChanged } | ||
| /> | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you renaming everything that was TextField to DefaultTextField? That feels counterintuitive.