Skip to content

ComboBox: Add getClassNames prop to allow complete customization of the component #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jspurlin merged 2 commits into from
Feb 13, 2018
Merged

ComboBox: Add getClassNames prop to allow complete customization of the component #3754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fdfe37
ComboBox: Add getClassNAmes prop to allow complete customization of t…
kysedate Jan 20, 2018
aeec2de
rush change
kysedate Jan 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .../changes/office-ui-fabric-react/kysedate-comboBox-getClassNamesProp_2018-01-20-02-14.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "ComboBox: Add getClassNAmes prop to allow complete customization of the component",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
30 changes: 20 additions & 10 deletions packages/office-ui-fabric-react/src/components/ComboBox/ComboBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,16 +281,26 @@ export class ComboBox extends BaseComponent<IComboBoxProps, IComboBoxState> {

let hasErrorMessage = (errorMessage && errorMessage.length > 0) ? true : false;

this._classNames = getClassNames(
getStyles(theme!, customStyles),
className!,
!!isOpen,
!!disabled,
!!required,
!!focused,
!!allowFreeform,
!!hasErrorMessage
);
this._classNames = this.props.getClassNames ?
this.props.getClassNames(
theme!,
!!isOpen,
!!disabled,
!!required,
!!focused,
!!allowFreeform,
!!hasErrorMessage,
className) :
getClassNames(
getStyles(theme!, customStyles),
className!,
!!isOpen,
!!disabled,
!!required,
!!focused,
!!allowFreeform,
!!hasErrorMessage
);

return (
<div {...divProps } ref='root' className={ this._classNames.container }>
Expand Down
16 changes: 16 additions & 0 deletions packages/office-ui-fabric-react/src/components/ComboBox/ComboBox.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { ISelectableDroppableTextProps } from '../../utilities/selectableOption/
import { IStyle, ITheme } from '../../Styling';
import { IButtonStyles } from '../../Button';
import { IRenderFunction } from '../../Utilities';
import { IComboBoxClassNames } from './ComboBox.classNames';

export interface IComboBox {
/**
Expand Down Expand Up @@ -101,6 +102,21 @@ export interface IComboBoxProps extends ISelectableDroppableTextProps<IComboBox>
*/
styles?: Partial<IComboBoxStyles>;

/**
* Custom function for providing the classNames for the ComboBox. Can be used to provide
* all styles for the component instead of applying them on top of the default styles.
*/
getClassNames?: (
theme: ITheme,
isOpen: boolean,
disabled: boolean,
required: boolean,
focused: boolean,
allowFreeForm: boolean,
hasErrorMessage: boolean,
className?: string
) => IComboBoxClassNames;

/**
* Styles for the caret down button.
*/
Expand Down