fix(release): fail fast on invalid web components credentials - #36566
Open
Jane Chu (janechu) wants to merge 1 commit into
Open
fix(release): fail fast on invalid web components credentials#36566Jane Chu (janechu) wants to merge 1 commit into
Jane Chu (janechu) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8069819a-0e6e-450d-9f10-59a2df1b15a0
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The web components release could complete build and test work before missing or invalid npm/GitHub credentials failed during publishing.
New Behavior
Non-dry-run releases validate npm identity plus GitHub identity and repository access immediately after dependency installation, before build and publish steps. Validation failures are sanitized so credential values are not logged; dry runs remain unchanged.
Testing
yarn nx run-many -t lint type-check test -p scripts-beachball --nxBail --skip-nx-cacheyarn nx format:check --files=azure-pipelines.release.web-components.yml,scripts/beachball/src/validateReleaseCredentials.ts,scripts/beachball/src/validateReleaseCredentials.test.tsNo beachball change file is included because no published package changed.
Related Issue(s)
None.