Skip to content

fix(react-headless-components-preview): use a custom renderTagPicker function so Portal isn't pulled in - #36553

Merged
Dmytro Kirpa (dmytrokirpa) merged 4 commits into
microsoft:masterfrom
dmytrokirpa:fix/headless-tag-picker-render
Aug 11, 2026
Merged

fix(react-headless-components-preview): use a custom renderTagPicker function so Portal isn't pulled in#36553
Dmytro Kirpa (dmytrokirpa) merged 4 commits into
microsoft:masterfrom
dmytrokirpa:fix/headless-tag-picker-render

Conversation

@dmytrokirpa

Copy link
Copy Markdown
Contributor

Previous Behavior

TagPicker pulled in Portal to headless components via renderTagPicker_unstable method

New Behavior

Inline custom render function for TagPicker following the same pattern we have for Drodpown/Combobox to avoid pulling Portal to the bundle

Related Issue(s)

  • Fixes #

@dmytrokirpa
Dmytro Kirpa (dmytrokirpa) requested a review from a team as a code owner August 11, 2026 13:43
@dmytrokirpa Dmytro Kirpa (dmytrokirpa) changed the title Fix/headless tag picker render fix(react-headless-components): headless tag picker render Aug 11, 2026
@dmytrokirpa Dmytro Kirpa (dmytrokirpa) changed the title fix(react-headless-components): headless tag picker render fix(react-headless-components-preview): use custom renderTagPicker function for TagPicker component to avoid pulling Portal Aug 11, 2026
@dmytrokirpa Dmytro Kirpa (dmytrokirpa) changed the title fix(react-headless-components-preview): use custom renderTagPicker function for TagPicker component to avoid pulling Portal fix(react-headless-components-preview): use custom renderTagPicker function to avoid pulling Portal Aug 11, 2026
@dmytrokirpa Dmytro Kirpa (dmytrokirpa) changed the title fix(react-headless-components-preview): use custom renderTagPicker function to avoid pulling Portal fix(react-headless-components-preview): use a custom renderTagPicker function so Portal isn't pulled in Aug 11, 2026
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-headless-components-preview
react-headless-components-preview: entire library
242.48 kB
69.418 kB
233.802 kB
66.247 kB
-8.678 kB
-3.171 kB
react-headless-components-preview
@fluentui/react-headless-components-preview/tag-picker
62.147 kB
20.587 kB
53.476 kB
17.51 kB
-8.671 kB
-3.077 kB
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-headless-components-preview
@fluentui/react-headless-components-preview/teaching-popover
35.416 kB
11.745 kB
🤖 This report was generated against e91455753fa2d5b5d666e5c02dbda78c12ae1901

@github-actions

Copy link
Copy Markdown

Pull request demo site: URL

@Hotell Martin Hochel (Hotell) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets goo

@dmytrokirpa
Dmytro Kirpa (dmytrokirpa) merged commit a47be84 into microsoft:master Aug 11, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants